mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yureka Lilian <yuka@yuka.dev>
To: samuel.thibault@ens-lyon.org
Cc: gregkh@linuxfoundation.org, chris@the-brannons.com,
	linux-kernel@vger.kernel.org, speakup@linux-speakup.org,
	w.d.hubbs@gmail.com, Yureka Lilian <yuka@yuka.dev>
Subject: [PATCH v2] speakup: remove usage of non-standard u_char
Date: Thu, 17 Nov 2022 01:12:44 +0100	[thread overview]
Message-ID: <20221117001244.212047-1-yuka@yuka.dev> (raw)

This code is included in the build tools makemapdata and genmap, and it
expects that libc exposes a definition of u_char. But u_char is not
defined in either C or POSIX standards, and some systems don't have it.
Namely this breaks the build on hosts using musl libc, because musl only
exposes u_char if _GNU_SOURCE is defined.

Signed-off-by: Yureka Lilian <yuka@yuka.dev>
Cc: stable@vger.kernel.org
---
Content is unchanged compared to v1, but hopefully the patch is not
corrupted this time and I added a cc: stable
---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..4ce9a12f7664 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
 
 static inline struct st_key *hash_name(char *name)
 {
-	u_char *pn = (u_char *)name;
+	unsigned char *pn = (unsigned char *)name;
 	int hash = 0;
 
 	while (*pn) {
-- 
2.38.1


             reply	other threads:[~2022-11-17  0:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  0:12 Yureka Lilian [this message]
2022-11-17  8:20 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117001244.212047-1-yuka@yuka.dev \
    --to=yuka@yuka.dev \
    --cc=chris@the-brannons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®