mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH 2/3] ext4: WANR_ON when detect abnormal 'i_reserved_data_blocks'
Date: Thu, 17 Nov 2022 09:42:45 +0800	[thread overview]
Message-ID: <20221117014246.610202-3-yebin@huaweicloud.com> (raw)
In-Reply-To: <20221117014246.610202-1-yebin@huaweicloud.com>

From: Ye Bin <yebin10@huawei.com>

If 'i_reserved_data_blocks' is not cleared which mean something wrong
with code, so emit WARN_ON to capture this abnormal closer to the first
scene.

Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 fs/ext4/super.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 63ef74eb8091..30885a6fe18b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1385,11 +1385,14 @@ static void ext4_destroy_inode(struct inode *inode)
 		dump_stack();
 	}
 
-	if (EXT4_I(inode)->i_reserved_data_blocks)
-		ext4_msg(inode->i_sb, KERN_ERR,
-			 "Inode %lu (%p): i_reserved_data_blocks (%u) not cleared!",
-			 inode->i_ino, EXT4_I(inode),
-			 EXT4_I(inode)->i_reserved_data_blocks);
+	if (EXT4_I(inode)->i_reserved_data_blocks) {
+		ext4_warning(inode->i_sb, "Inode %lu (%p): "
+			    "i_reserved_data_blocks (%u) not cleared!",
+			     inode->i_ino, EXT4_I(inode),
+			     EXT4_I(inode)->i_reserved_data_blocks);
+
+		WARN_ON(1);
+	}
 }
 
 static void init_once(void *foo)
-- 
2.31.1


  parent reply	other threads:[~2022-11-17  1:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  1:42 [PATCH 0/3] Fix two issues about bigalloc feature Ye Bin
2022-11-17  1:42 ` [PATCH 1/3] ext4: fix incorrect calculate 'reserved' in '__es_remove_extent' when enable " Ye Bin
2022-11-17  1:42 ` Ye Bin [this message]
2022-11-21  9:47   ` [PATCH 2/3] ext4: WANR_ON when detect abnormal 'i_reserved_data_blocks' Jan Kara
2022-11-21 11:14     ` yebin (H)
2022-11-17  1:42 ` [PATCH 3/3] ext4: add check pending tree when evict inode Ye Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117014246.610202-3-yebin@huaweicloud.com \
    --to=yebin@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®