From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D482C4332F for ; Thu, 17 Nov 2022 15:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239531AbiKQPXT (ORCPT ); Thu, 17 Nov 2022 10:23:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234885AbiKQPWd (ORCPT ); Thu, 17 Nov 2022 10:22:33 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8CA2C1 for ; Thu, 17 Nov 2022 07:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668698394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TobA0krOtaSl7P1GGJ20EZXgKGm0ZbyqFXKercBRCd0=; b=DBCTzn4lPOgPyl6vpbHFUmAEHOj4gsS2htrgVYMjehly4SrWtpAnScREeCRZNbMMQ8malO OXdckp9tPN58V6D47E3MUfpWGcbmbXUS/N/H3yju4OLG1qWt/Wf24x0PlUIpRc4HVfTsUe eCSJFfm5vY0T4ycMB/TiIvuaUIhpFiI= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-649-gj-mWowGNS2PRrosNcFOIQ-1; Thu, 17 Nov 2022 10:19:53 -0500 X-MC-Unique: gj-mWowGNS2PRrosNcFOIQ-1 Received: by mail-oo1-f71.google.com with SMTP id u5-20020a4a6145000000b0049f4b251d54so1045449ooe.13 for ; Thu, 17 Nov 2022 07:19:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TobA0krOtaSl7P1GGJ20EZXgKGm0ZbyqFXKercBRCd0=; b=R6u0ckb4X/01zBj4tDrc32oihGmr26KfRXqKveNXSf9k9cZHXQFfJ6m1RpNeTlWmYT PWHC7HAJ2ob8oFIvWRYHcAog8goIEGsb8o3D3YWAAmiw9VJWfvgpTryOGGrCWdVM4yRf iIjZlVm88fnzG1hKmmQ4xUKhg9FpBp9fcmRDAuCjl/puhFfaTi4T/Mg+4N79coS1v4jW 9hFPVpx65G43i24BjI2SEtwI3MT1GmfYw+bx6/IhVousspMWMrG81pzwHPEzB7gWog68 BqI16cmWhnINE8BJIFJuGT2mKWURXSYqXL8m1yVbyBfwTbS1w+JPhve0FyYEA4Ygfm8i HwEw== X-Gm-Message-State: ANoB5pkXdWY7/3BUokymZQCuMKi4DB0TzP0Nh5LoCKO3EDyFoUVtLtNN W63VW3itiwj7LI/6kSKSC+jWTmVNjxgMOeZxwBdcaww9RvZ3PJuzuLHx4RtO1HG0/xXyMpOwO12 3T4VSGOOrx7aTkBnW9vk4QYu7 X-Received: by 2002:a05:6808:1719:b0:35a:f1e9:6536 with SMTP id bc25-20020a056808171900b0035af1e96536mr1404877oib.100.1668698392317; Thu, 17 Nov 2022 07:19:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5qkQT8FtSupazP+csDv9DFb452dAxzo2zNrweRI6MELBpkfXftBeXXuY0hsdYkndSa5d/3GQ== X-Received: by 2002:a05:6808:1719:b0:35a:f1e9:6536 with SMTP id bc25-20020a056808171900b0035af1e96536mr1404850oib.100.1668698392000; Thu, 17 Nov 2022 07:19:52 -0800 (PST) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id u1-20020a056808000100b003546fada8f6sm404205oic.12.2022.11.17.07.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 07:19:51 -0800 (PST) Date: Thu, 17 Nov 2022 09:19:49 -0600 From: Andrew Halaney To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Douglas Anderson , Saravana Kannan , Daniel Vetter , linux-arm-msm@vger.kernel.org, John Stultz , Peter Robinson , Steev Klimaszewski , Greg Kroah-Hartman , Enric Balletbo i Serra , Bjorn Andersson , Brian Masney , Rob Herring Subject: Re: [PATCH v2 3/4] driver core: Add fw_devlink.timeout param to stop waiting for devlinks Message-ID: <20221117151949.3cbc6cwphnv4scze@halaney-x13s> References: <20221116115348.517599-1-javierm@redhat.com> <20221116120159.519908-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116120159.519908-1-javierm@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16, 2022 at 01:01:59PM +0100, Javier Martinez Canillas wrote: > Currently, the probe deferral timeout does two things: > > 1) Call to fw_devlink_drivers_done() to relax the device dependencies and > allow drivers to be probed if these dependencies are optional. > > 2) Disable the probe deferral mechanism so that drivers will fail to probe > if the required dependencies are not present, instead of adding them to > the deferred probe pending list. > > But there is no need to couple these two, for example the probe deferral > can be used even when the device links are disable (i.e: fw_devlink=off). > > So let's add a separate fw_devlink.timeout command line parameter to allow > relaxing the device links and prevent drivers to wait for these to probe. > > Signed-off-by: Javier Martinez Canillas > --- > > (no changes since v1) > > .../admin-guide/kernel-parameters.txt | 7 ++++ > drivers/base/dd.c | 38 ++++++++++++++++++- > 2 files changed, 44 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index a465d5242774..38138a44d5ed 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1581,6 +1581,13 @@ > dependencies. This only applies for fw_devlink=on|rpm. > Format: > > + fw_devlink.timeout= Just thought about this, but I think this should be called fw_devlink_timeout. Generally the $MODULE.$PARAM syntax is reserved for things that can be specificed with module_param(). The advantage is if you accidentally type say fw_devlink_timeut=10 the kernel logs will indicate it has no clue what that means. Including the "." makes the kernel assume that maybe a future module name fw_devlink will be loaded, and at that time will see if that module has the parameter mentioned. A little thing but I think work changing in v3. Thanks, Andrew