From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3803C433FE for ; Thu, 17 Nov 2022 20:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240441AbiKQUgj (ORCPT ); Thu, 17 Nov 2022 15:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235060AbiKQUgg (ORCPT ); Thu, 17 Nov 2022 15:36:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3326585A for ; Thu, 17 Nov 2022 12:36:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2F4FBB82072 for ; Thu, 17 Nov 2022 20:36:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 321A6C433D6; Thu, 17 Nov 2022 20:36:32 +0000 (UTC) Date: Thu, 17 Nov 2022 15:36:30 -0500 From: Steven Rostedt To: Wang Wensheng Cc: , , , , Subject: Re: [PATCH -next 3/3] ftrace: Delete unused variable ftrace_update_time Message-ID: <20221117153630.4af6a7da@gandalf.local.home> In-Reply-To: <20221109094434.84046-4-wangwensheng4@huawei.com> References: <20221109094434.84046-1-wangwensheng4@huawei.com> <20221109094434.84046-4-wangwensheng4@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Nov 2022 09:44:34 +0000 Wang Wensheng wrote: > ftrace_update_time is not used anywhere else after initialization. So > delete it together with its initial code. Thanks for the first two patches. They are definitely fixes and I plan on testing and adding them to my next pull request. As for this one, this has been more of a reminder for me to one day (I know, it's been years!) to export this to see from user space. I sometimes do it manually with a printk(), but it should probably be always shown. Perhaps in dyn_ftrace_total_info ? -- Steve