From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D4EC4332F for ; Thu, 17 Nov 2022 17:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234987AbiKQRsf (ORCPT ); Thu, 17 Nov 2022 12:48:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234664AbiKQRsb (ORCPT ); Thu, 17 Nov 2022 12:48:31 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86980FE4; Thu, 17 Nov 2022 09:48:28 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id w15-20020a17090a380f00b0021873113cb4so2259582pjb.0; Thu, 17 Nov 2022 09:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s1yYyNmZdv0daCGoHPHS3FUErcT+tuPk7PSjFra0en8=; b=cGLj1pwtomgmbByfX6WX1U5VFKSYmw1CoVvTun74RZ1F5WUcqXYadMBeRKWnQD4sbD UEtWkhVQMvidb7CS/SwYw5dMznbXkc1A2fjJ7P+AD6C+5UoEgKJc3CbYekdSMe2F3rGO iPfq0sUfX2kgjHUCJi+1SPy7G5pmwUsf/HZUih8Z7edJP8AdfSmBYgO/EJoCHv67bMfJ ly9iIYlmBxqawthD3cxy2wmryDHf85BW52l0PniSXiv9uuZVSms5B6XUIImmEl8ZAnlM c0o2d9ed96ww9fRCky1LsXK6DQD4vVAQiy5Mwvd4a0Yv83J3zxKMiHzxDt/Qi0mabbZP 2qTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s1yYyNmZdv0daCGoHPHS3FUErcT+tuPk7PSjFra0en8=; b=PBZJmLIfcbmNkCYaSS+yLER1SDwOOHy3zuaV/uehJSblO1NB25WtsvrndbFahelSXo gbPoE6Jz8wy1oL4HsZDwc/40jf6KH3TSGoEKbi84cR68r2lhlk7XDswFn/JYADntE2s6 UM9NrXvYNjX2dRWcVNGRCkMnP+QWSs8Hm4PfvKvapSjCOiwbgMopg2o/P4iBcJxSmPGM q1gOpHG/7fti4WsecyyTPSWbGjOsSr4y3h+wioIIFUnutF5TeOahNmrf23otpFK/C/rE amge5m60GGgtKugtt5+fJhgc0nysltpjcqrn/MB1zfyS357KFgfBZ9XGOxyWy9h1qCgN mWeQ== X-Gm-Message-State: ANoB5plLyq4BRhFq6jf+DsuGjvu8Rz7ozo51Yu0tQds+L7lJxKn9gMp8 aufdPzuD5p060d2rAP1epTdZQf4Aols= X-Google-Smtp-Source: AA0mqf4Bqehu/lUEeB16X4B1QBG8C+LCUyw88XLJlnfIwVSP0sizWnH3+FPhFqN4bJVqPLWWSrlqWw== X-Received: by 2002:a17:902:8d92:b0:182:e9dd:936d with SMTP id v18-20020a1709028d9200b00182e9dd936dmr3949002plo.6.1668707307958; Thu, 17 Nov 2022 09:48:27 -0800 (PST) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id r8-20020a63ce48000000b0046feca0883fsm1233253pgi.64.2022.11.17.09.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 09:48:27 -0800 (PST) Date: Thu, 17 Nov 2022 09:48:26 -0800 From: Isaku Yamahata To: Sagi Shahar Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , David Matlack , Sean Christopherson , Kai Huang Subject: Re: [PATCH v10 016/108] KVM: TDX: create/destroy VM structure Message-ID: <20221117174826.GE2350331@ls.amr.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 04:06:10PM -0800, Sagi Shahar wrote: > > +int tdx_vm_init(struct kvm *kvm) > > +{ > > + struct kvm_tdx *kvm_tdx = to_kvm_tdx(kvm); > > + cpumask_var_t packages; > > + int ret, i; > > + u64 err; > > + > > + ret = tdx_keyid_alloc(); > > Can we skip the hkid allocation at such an early stage? > This makes intra-host migration more complicated as the hkid of the > destination VM is already allocated before we have a chance to migrate > the state from the source VM. > > I remember you had an internal version that already did that in > https://github.com/intel/tdx/blob/552dd80c48f67ca01bcdd10667e0c11efd375177/arch/x86/kvm/vmx/tdx.c#L508 With the patch of "KVM: TDX: initialize VM with TDX specific parameters", the allocation code is split out into its own code with KVM_TDX_INIT_VM. I think that's what you want. -- Isaku Yamahata