Hi ruanjinjie, Thank you for the patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on helgaas-pci/for-linus linus/master v6.1-rc5 next-20221118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/ruanjinjie/PCI-dwc-add-missing-free_irq-in-ks_pcie_remove-and-error-path-in-ks_pcie_probe/20221116-102615 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next patch link: https://lore.kernel.org/r/20221116022147.2636355-1-ruanjinjie%40huawei.com patch subject: [PATCH] PCI: dwc: add missing free_irq() in ks_pcie_remove() and error path in ks_pcie_probe() config: parisc-randconfig-r002-20221115 compiler: hppa-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7e5242b1d6838ee186e17b970fd3516cbe2e41a8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review ruanjinjie/PCI-dwc-add-missing-free_irq-in-ks_pcie_remove-and-error-path-in-ks_pcie_probe/20221116-102615 git checkout 7e5242b1d6838ee186e17b970fd3516cbe2e41a8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pci/controller/dwc/pci-keystone.c: In function 'ks_pcie_remove': >> drivers/pci/controller/dwc/pci-keystone.c:1324:18: error: 'irq' undeclared (first use in this function); did you mean 'rq'? 1324 | free_irq(irq, ks_pcie); | ^~~ | rq drivers/pci/controller/dwc/pci-keystone.c:1324:18: note: each undeclared identifier is reported only once for each function it appears in vim +1324 drivers/pci/controller/dwc/pci-keystone.c 1311 1312 static int __exit ks_pcie_remove(struct platform_device *pdev) 1313 { 1314 struct keystone_pcie *ks_pcie = platform_get_drvdata(pdev); 1315 struct device_link **link = ks_pcie->link; 1316 int num_lanes = ks_pcie->num_lanes; 1317 struct device *dev = &pdev->dev; 1318 1319 pm_runtime_put(dev); 1320 pm_runtime_disable(dev); 1321 ks_pcie_disable_phy(ks_pcie); 1322 while (num_lanes--) 1323 device_link_del(link[num_lanes]); > 1324 free_irq(irq, ks_pcie); 1325 1326 return 0; 1327 } 1328 -- 0-DAY CI Kernel Test Service https://01.org/lkp