From: Jacob Macneal <jake.macneal@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: jake.macneal@gmail.com, John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>
Subject: [PATCH] time: copy tai value (International Atomic Time, in seconds) to output __user struct in get_old_timex32().
Date: Mon, 21 Nov 2022 00:53:45 -0500 [thread overview]
Message-ID: <20221121055345.111567-1-jake.macneal@gmail.com> (raw)
Previously, this value was not copied into the output struct. This is
despite all other fields of the corresponding __kernel_timex struct being
copied to the old_timex32 __user struct in this function.
Additionally, the matching function put_old_timex32() expects a tai value
to be supplied, and copies it appropriately. It would appear to be a
mistake that this value was never copied over in get_old_timex32().
Signed-off-by: Jacob Macneal <jake.macneal@gmail.com>
---
kernel/time/time.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/time.c b/kernel/time/time.c
index 526257b3727c..7da9951b033a 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -311,6 +311,7 @@ int get_old_timex32(struct __kernel_timex *txc, const struct old_timex32 __user
txc->calcnt = tx32.calcnt;
txc->errcnt = tx32.errcnt;
txc->stbcnt = tx32.stbcnt;
+ txc->tai = tx32.tai;
return 0;
}
--
2.32.0
next reply other threads:[~2022-11-21 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 5:53 Jacob Macneal [this message]
2022-11-23 18:54 ` John Stultz
2022-11-23 19:53 ` Arnd Bergmann
2022-11-23 20:29 ` John Stultz
2022-12-01 12:41 ` Thomas Gleixner
2022-12-01 13:47 ` Thomas Gleixner
[not found] ` <CAHn5w+piDmr2iJGo74BCOW6QApEgJmd0p2Z0TZgxU3X6PiJiAA@mail.gmail.com>
2022-12-01 15:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121055345.111567-1-jake.macneal@gmail.com \
--to=jake.macneal@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®