From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8748C43217 for ; Mon, 21 Nov 2022 11:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbiKUL6M (ORCPT ); Mon, 21 Nov 2022 06:58:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbiKUL6H (ORCPT ); Mon, 21 Nov 2022 06:58:07 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4808BE010 for ; Mon, 21 Nov 2022 03:57:58 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id f27so28041733eje.1 for ; Mon, 21 Nov 2022 03:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MBbsIuonafwREhzlZL+FNmZyLBn3gGtNW8dW5Tq4ubo=; b=rMXy/vvwEhXKozlAX1RwrPPT42CNokrusCoQoaRmpnG1Qk15lltVbnd3j2iAUlPdCs ti02LF5TBqoq6YtuHwOVTeMM8V3j9A/NyTYlxdqupHWMVJXHr1OdUGXBc1PgZ4MAwDHo jBrJsSHfGHJvwDXnWS7nntzTuJE+2sCrNmMBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MBbsIuonafwREhzlZL+FNmZyLBn3gGtNW8dW5Tq4ubo=; b=Tg8U77eApMR8viBr1I7P6BlmcyJBmTnV/xFdAffHhoH6d2iFruLnE2uJ4j4L0hopJN 0ZYeieJQWIadJCK8XI92uwhV6uuHk6bQVpjUbPPcG7GqoqjP9Pl+13iizaOMHHcAjjkC SgBBe72tw1ffF2bKYkjcIwU+pHZlB8R2Gr0fGt7xWxFNRRddrq2xSjBtsaPfri1JDLaR NNlCikH0hgWiEaHM1rJXSMPBkEqEWV0IkOcqFesy6VgxrQk/oNIW88KcD3Cn7j6rbYxv 4HgLZTLErNvLMzHy4gGxYT7T1zw84bV5C7CxBdBL+Zth+3/i0f5jHNsGPs5qaO9SqRIp 855A== X-Gm-Message-State: ANoB5pkZyJqM4cjSu21lebrM+pb2m4C2RKiKyDNmH17zD24YCCh1dDWt b4iucP7D4oziJpbIyYtcT2cLsA== X-Google-Smtp-Source: AA0mqf4GqPNprIWVxYHjPd6mEdI7a0BfxK3crJG0H7ykmiHCidUbmzKoQBMNZ5VBRsnmPvjpZMda8Q== X-Received: by 2002:a17:906:2342:b0:78d:9e77:1f8c with SMTP id m2-20020a170906234200b0078d9e771f8cmr6710101eja.236.1669031876837; Mon, 21 Nov 2022 03:57:56 -0800 (PST) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-55-94.cust.vodafonedsl.it. [188.217.55.94]) by smtp.gmail.com with ESMTPSA id k19-20020aa7c053000000b00456c6b4b777sm5037181edo.69.2022.11.21.03.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 03:57:56 -0800 (PST) Date: Mon, 21 Nov 2022 12:57:54 +0100 From: Tommaso Merciai To: Wang Yufen Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, sumit.semwal@linaro.org, christian.koenig@amd.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer Message-ID: <20221121115754.GA39395@tom-ThinkPad-T14s-Gen-2i> References: <1669025872-44226-1-git-send-email-wangyufen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1669025872-44226-1-git-send-email-wangyufen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wang, On Mon, Nov 21, 2022 at 06:17:52PM +0800, Wang Yufen wrote: > Fix to return a negative error code from the gi2c->err instead of > 0. > > Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") > Signed-off-by: Wang Yufen > --- > drivers/i2c/busses/i2c-qcom-geni.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 84a7751..8fce98b 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i > dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", > gi2c->cur->flags, gi2c->cur->addr); > gi2c->err = -ETIMEDOUT; > - goto err; Looks good to me. Reviewed-by: Tommaso Merciai Regards, Tommaso > } > > if (gi2c->err) { > -- > 1.8.3.1 > -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com