From: Andrew Morton <akpm@linux-foundation.org>
To: Xu Qiang <xuqiang36@huawei.com>
Cc: <pmladek@suse.com>, <mcgrof@kernel.org>, <elver@google.com>,
<gpiccoli@igalia.com>, <bigeasy@linutronix.de>,
<tangmeng@uniontech.com>, <andriy.shevchenko@linux.intel.com>,
<yangtiezhu@loongson.cn>, <john.ogness@linutronix.de>,
<daniel.vetter@ffwll.ch>, <linux-kernel@vger.kernel.org>,
<weiyongjun1@huawei.com>
Subject: Re: [PATCH RESEND] panic: Add register_panic_notifier and unregister_panic_notifier
Date: Mon, 21 Nov 2022 13:57:08 -0800 [thread overview]
Message-ID: <20221121135708.47f9a852a81d664a9b695336@linux-foundation.org> (raw)
In-Reply-To: <20221119080305.111863-1-xuqiang36@huawei.com>
On Sat, 19 Nov 2022 08:03:05 +0000 Xu Qiang <xuqiang36@huawei.com> wrote:
> Add two methods to manipulate panic_notifier_list and export them.
> Subsequently, panic_notifier_list is changed to static variable.
Fair enough, I guess. But...
- It would be better to include a followup patch which converts at
least some of the existing sites, so we know the code is getting
tested.
- Better names would be panic_notifier_register() and
panic_notifier_unregister()
- You forgot to make panic_notifier_list static to panic.c.
prev parent reply other threads:[~2022-11-21 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 8:03 Xu Qiang
2022-11-20 15:41 ` Guilherme G. Piccoli
2022-11-21 21:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121135708.47f9a852a81d664a9b695336@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=daniel.vetter@ffwll.ch \
--cc=elver@google.com \
--cc=gpiccoli@igalia.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
--cc=tangmeng@uniontech.com \
--cc=weiyongjun1@huawei.com \
--cc=xuqiang36@huawei.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®