From: Nishanth Menon <nm@ti.com>
To: Georgi Vlaev <g-vlaev@ti.com>
Cc: Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Vibhore Vardhan <vibhore@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH v4 3/5] firmware: ti_sci: Allocate memory for the LPM modes
Date: Mon, 21 Nov 2022 12:56:27 -0600 [thread overview]
Message-ID: <20221121185627.lysq4u7guiprclxt@surviving> (raw)
In-Reply-To: <20221116181307.198209-4-g-vlaev@ti.com>
On 20:13-20221116, Georgi Vlaev wrote:
> + /*
> + * Attempt to call prepare_sleep, this will be NAK'd if suspend is not
> + * supported by firmware in use, in which case we will not attempt to
> + * init suspend.
> + */
> + ret = ti_sci_cmd_prepare_sleep(&info->handle, 0,
> + (u32)(info->ctx_mem_addr & 0xffffffff),
> + (u32)((u64)info->ctx_mem_addr >> 32), 0);
> +
https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html#tisci-msg-prepare-sleep
"Prepare the SOC for entering into a low power mode."
But we are in the init process here. From the documentation, firmware
does'nt seem to guarantee it would do something unexpected (like setup
io daisy chain or something like that which normal LP entry state
would have to do) - How is it safe to use it as a discovery of
capability API?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-11-21 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 18:13 [PATCH v4 0/5] firmware: ti_sci: Introduce system suspend support Georgi Vlaev
2022-11-16 18:13 ` [PATCH v4 1/5] dt-bindings: ti, sci: Add lpm region and firmware-name Georgi Vlaev
2022-11-18 12:59 ` Krzysztof Kozlowski
2022-11-21 22:26 ` Georgi Vlaev
2022-11-16 18:13 ` [PATCH v4 2/5] firmware: ti_sci: Introduce Power Management Ops Georgi Vlaev
2022-11-16 18:13 ` [PATCH v4 3/5] firmware: ti_sci: Allocate memory for the LPM modes Georgi Vlaev
2022-11-21 18:44 ` Nishanth Menon
2022-11-21 21:45 ` Georgi Vlaev
2022-11-21 18:56 ` Nishanth Menon [this message]
2022-11-21 22:03 ` Georgi Vlaev
2022-11-16 18:13 ` [PATCH v4 4/5] firmware: ti_sci: Use dt provided fw name and address to load at suspend time Georgi Vlaev
2022-11-16 18:13 ` [PATCH v4 5/5] firmware: ti_sci: Introduce prepare system suspend call Georgi Vlaev
2022-11-23 12:58 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121185627.lysq4u7guiprclxt@surviving \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=g-vlaev@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®