From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62047C433FE for ; Tue, 22 Nov 2022 00:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbiKVAkd (ORCPT ); Mon, 21 Nov 2022 19:40:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiKVAk2 (ORCPT ); Mon, 21 Nov 2022 19:40:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D73342721 for ; Mon, 21 Nov 2022 16:40:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 910ADB818BF for ; Tue, 22 Nov 2022 00:40:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F72C433C1; Tue, 22 Nov 2022 00:40:23 +0000 (UTC) Date: Mon, 21 Nov 2022 19:40:22 -0500 From: Steven Rostedt To: Alexei Starovoitov Cc: Borislav Petkov , LKML , Linus Torvalds , Masami Hiramatsu , Andrew Morton , Peter Zijlstra , Kees Cook , Josh Poimboeuf , KP Singh , Chris Mason , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig Subject: Re: [PATCH] error-injection: Add prompt for function error injection Message-ID: <20221121194022.683e22c7@gandalf.local.home> In-Reply-To: <20221121192423.1ab25c4d@gandalf.local.home> References: <20221121104403.1545f9b5@gandalf.local.home> <20221121192423.1ab25c4d@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Nov 2022 19:24:23 -0500 Steven Rostedt wrote: > On Mon, 21 Nov 2022 15:36:08 -0800 > Alexei Starovoitov wrote: > > > The commit log is bogus and the lack of understanding what > > bpf and error injection hooks are used for expressed > > in this thread is quite sad. > > Disabling error injection makes the system _less_ secure. > > Please specify. > > As Masami replied, you are abusing this feature for some arcane way to do > security. It's "error injection" how does enabling this improve security??? > If you want to add BPF programs to determine who or what can access various functions, then please work with the security folks and hook into their infrastructure. Please do not make some home grown operations on top of an interface that was not created for this purpose. That can only lead to unexpected consequences. -- Steve