From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15874C433FE for ; Tue, 22 Nov 2022 22:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235113AbiKVWI0 (ORCPT ); Tue, 22 Nov 2022 17:08:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235110AbiKVWIM (ORCPT ); Tue, 22 Nov 2022 17:08:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2150C70186 for ; Tue, 22 Nov 2022 14:07:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE2AE618E5 for ; Tue, 22 Nov 2022 22:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C800C433C1; Tue, 22 Nov 2022 22:07:55 +0000 (UTC) Date: Tue, 22 Nov 2022 17:07:54 -0500 From: Steven Rostedt To: Mark Rutland Cc: linux-kernel@vger.kernel.org, mhiramat@kernel.org, revest@chromium.org Subject: Re: [PATCH 2/3] ftrace: export ftrace_free_filter() to modules Message-ID: <20221122170754.7962724c@gandalf.local.home> In-Reply-To: <20221122165938.353ee7c0@gandalf.local.home> References: <20221103170907.931465-1-mark.rutland@arm.com> <20221103170907.931465-3-mark.rutland@arm.com> <20221122165938.353ee7c0@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Nov 2022 16:59:38 -0500 Steven Rostedt wrote: > > + * This can allocate memory which must be freed before @ops can be freed, > > + * either by remvoing eached filtered addr or by using > > I love how you cut and pasted two typos four times. ;-) Besides the "remvoing" and "eached"... Reviewed-by: Steven Rostedt (Google) But please send a v2. -- Steve