mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: JaimeLiao <jaimeliao.tw@gmail.com>
To: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org
Cc: jaimeliao@mxic.com.tw, leoyu@mxic.com.tw, alvinzhou@mxic.com.tw,
	juliensu@mxic.com.tw, JaimeLiao <jaimeliao.tw@gmail.com>
Subject: [PATCH] memory: renesas-rpc-if: Fix missing setting address
Date: Wed, 23 Nov 2022 10:51:41 +0800	[thread overview]
Message-ID: <20221123025141.4012-1-jaimeliao.tw@gmail.com> (raw)

In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.

Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>
---
 drivers/memory/renesas-rpc-if.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 4316988d791a..bdf0a7f68ff2 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
 		}
 		break;
 	default:
+		regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
 		regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
 		regmap_write(rpc->regmap, RPCIF_SMCR,
 			     rpc->smcr | RPCIF_SMCR_SPIE);
-- 
2.17.1


             reply	other threads:[~2022-11-23  2:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  2:51 JaimeLiao [this message]
2022-12-27  8:59 ` Krzysztof Kozlowski
2023-01-23 10:47   ` Krzysztof Kozlowski
2023-01-23 10:44 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123025141.4012-1-jaimeliao.tw@gmail.com \
    --to=jaimeliao.tw@gmail.com \
    --cc=alvinzhou@mxic.com.tw \
    --cc=jaimeliao@mxic.com.tw \
    --cc=juliensu@mxic.com.tw \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=leoyu@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®