From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC350C433FE for ; Wed, 23 Nov 2022 10:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235921AbiKWKti (ORCPT ); Wed, 23 Nov 2022 05:49:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237038AbiKWKtJ (ORCPT ); Wed, 23 Nov 2022 05:49:09 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB6915F2A9 for ; Wed, 23 Nov 2022 02:35:33 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id b8so13448978edf.11 for ; Wed, 23 Nov 2022 02:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fdk6ayM1Ct66O9yHo4VxrA9gKbs+xznnUkFGTJiMlC0=; b=ixd/SW/4mbmK6Eq8U/7u9FDripN0Ee0KDzFNOLNcZkTXpLexIRwydzZqRg+uK2N2Ru Dcdxr5iVaE74MXUhXzk1nNzoxluSpStPsJ/g5j/xJskSFfxW5u2r9voPSKtL08AendVN 3nlEF2kGhoNuamYFmkMBRY1/o/FaI4tEX6WcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fdk6ayM1Ct66O9yHo4VxrA9gKbs+xznnUkFGTJiMlC0=; b=u9AthH4LXYPgfmyetsBOapDZkLwkrjAA9FtJcTNp4O5XcIUsWAMnb4f0YoWxVPnHF4 869y2u81AsLzd7O/3ejE6IIBHIksnty6CfApCdvU2vCLcpL1ysy0dWycfwUOY9XQ7ixh m/CMJYmbwFqP+lcX4ctfeO/sl6Tq4LLmE2mhFFrJ0GqZ7ranEHDrBNbjgOZYMHRdDkk+ qK9eMFITd1bCMVjvudbe/XnhQ3AMMn7L/+S0EVU4QsbdAkoNGGm1C9xAj+B5j02awsFa QSHD4ldAfixk9rgNMQ0p0FcpkIOTXI55kHLoBAQ4ejYH/IF1VXfUbjlqkheOVn0F08Q8 VX8Q== X-Gm-Message-State: ANoB5pnMgTTeYsTpqU0TMqlZCeFDD0aLIMy/E1Uc5uwRNCJNJ6oYETka llya9LeuvqgEsyXOA1Fquxtadg== X-Google-Smtp-Source: AA0mqf74EvznZPyWVMWqJcVg8W8zFDmrOicPF2lAdmAcsc0cuX+YS8xaKiCmanEDyWJxlD9Befz3bw== X-Received: by 2002:a05:6402:291b:b0:461:60b1:5c6d with SMTP id ee27-20020a056402291b00b0046160b15c6dmr13199766edb.182.1669199720603; Wed, 23 Nov 2022 02:35:20 -0800 (PST) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-55-94.cust.vodafonedsl.it. [188.217.55.94]) by smtp.gmail.com with ESMTPSA id e12-20020a1709062c0c00b0073d7b876621sm7043433ejh.205.2022.11.23.02.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 02:35:19 -0800 (PST) Date: Wed, 23 Nov 2022 11:35:17 +0100 From: Tommaso Merciai To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Laurent Pinchart , Andrzej Pietrasiewicz , Ricardo Ribalda , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] media: staging: stkwebcam: Restore MEDIA_{USB,CAMERA}_SUPPORT dependencies Message-ID: <20221123103517.GA2874916@tom-ThinkPad-T14s-Gen-2i> References: <20221123100831.GE39395@tom-ThinkPad-T14s-Gen-2i> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gaert, On Wed, Nov 23, 2022 at 11:13:31AM +0100, Geert Uytterhoeven wrote: > Hi Tommaso, > > On Wed, Nov 23, 2022 at 11:08 AM Tommaso Merciai > wrote: > > On Mon, Nov 21, 2022 at 04:58:33PM +0100, Geert Uytterhoeven wrote: > > > By moving support for the USB Syntek DC1125 Camera to staging, the > > > dependencies on MEDIA_USB_SUPPORT and MEDIA_CAMERA_SUPPORT were lost. > > > > > > Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging") > > > > Patch itself looks good but we have some style issue. Applying this > > patch I got the following warning from checkpatchl: > > > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging")' > > #10: > > > > You have to pass only the first 12 chars of the sha1 commit into Fixes > > msg: > > > > Use: > > > > Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging") > > > > Instead of: > > > > Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging") > > I always use 16 chars, to avoid these becoming ambiguous in a few years. > > Gr{oetje,eeting}s, Thanks for sharing this info. Regards, Tommaso > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com