From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A71C433FE for ; Thu, 24 Nov 2022 11:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbiKXL5O (ORCPT ); Thu, 24 Nov 2022 06:57:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbiKXL5M (ORCPT ); Thu, 24 Nov 2022 06:57:12 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 094AAC6611 for ; Thu, 24 Nov 2022 03:57:11 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47C2223A; Thu, 24 Nov 2022 03:57:17 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03C543F73D; Thu, 24 Nov 2022 03:57:09 -0800 (PST) Date: Thu, 24 Nov 2022 11:57:07 +0000 From: Sudeep Holla To: =?utf-8?B?546L5rSq6L6J?= Cc: Cristian Maruss , Jassi Brar , linux-arm-kernel , linux-kernel Subject: Re: =?utf-8?B?UmXvvJpSZQ==?= =?utf-8?Q?=3A?= [PATCH 3/3] arm_scpi: modify to support acpi Message-ID: <20221124115707.e5hsb5we25rzstv6@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wang, Please use text for your emails. I think it is html and I can't read it. On Thu, Nov 24, 2022 at 07:17:32PM +0800, 王洪辉 wrote: > For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU temp & freq, This patch is for the case, I had test ok on Phytium FT2000/4 plantform. And please append Patch V2 3/3. > >                                                                                     ---原始邮件--- > 发件人:"Sudeep Holla" 发送时间:2022年11月24日(星期四) 晚上7:10 > 收件人:"Wang Honghui" 主题: [PATCH 3/3] arm_scpi: modify to support acpi > Hi W                                                                             > ------------------ Original ------------------ > From: "Sudeep Holla" Date: Thu, Nov 24, 2022 07:10 PM > To: "Wang Honghui" Cc: "Cristian Maruss" Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi Doing %s/ / /g gave me: > For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU > temp & freq, This patch is for the case, I had test ok on Phytium > FT2000/4 plantform. And please append Patch V2 3/3. Let me repeat. You must use PCC driver without any phytium ft2000/4 platform code. All platform specific code and SCPI protocol must be hidden/abstracted in ACPI AML. Your changes are not acceptable for upstream. No change will be allowed in SCPI for ACPI as it needs to go in the firmware tables. Also I noticed drivers/mailbox/phytium_mailbox.c doesn't exist. So this patch is wrong in so many ways. Please check on how to represent phytium_mailbox hardware using ACPI PCC and add AML code that uses SCPI to achieve whatever you want. You may want to check on how to use PCC OpRegion as well in ACPI. -- Regards, Sudeep