mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: "Elliott, Robert (Servers)" <elliott@hpe.com>,
	Phillip Lougher <phillip@squashfs.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	"phillip.lougher@gmail.com" <phillip.lougher@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: BUG: BISECTED: in squashfs_xz_uncompress() (Was: RCU stalls in squashfs_readahead())
Date: Thu, 24 Nov 2022 12:15:52 -0800	[thread overview]
Message-ID: <20221124201552.GV4001@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <9486bc0a-345e-a93c-581f-50e2a06a3314@alu.unizg.hr>

On Thu, Nov 24, 2022 at 07:04:13PM +0100, Mirsad Goran Todorovac wrote:
> On 24. 11. 2022. 18:19, Paul E. McKenney wrote:
> > On Thu, Nov 24, 2022 at 06:06:13PM +0100, Mirsad Goran Todorovac wrote:
> > > On 23. 11. 2022. 20:09, Paul E. McKenney wrote:
> > > 
> > > > > > If you build with (say) CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=200, does
> > > > > > this still happen?
> > > > > 
> > > > > BTW, you don't need to rebuild the kernel to change those parameters; they're
> > > > > module parameters, so can be modified on the kernel command line (if needed
> > > > > during boot) and sysfs (if only needed after boot).
> > > > > 
> > > > > For sysfs the syntax is:
> > > > > #!/bin/bash
> > > > > # set rcu timeouts to specified values
> > > > > echo 60 > /sys/module/rcupdate/parameters/rcu_cpu_stall_timeout
> > > > > echo 21000 > /sys/module/rcupdate/parameters/rcu_exp_cpu_stall_timeout
> > > > > echo 600000 > /sys/module/rcupdate/parameters/rcu_task_stall_timeout
> > > > > grep -Hs . /sys/module/rcupdate/parameters/rcu_*_timeout
> > > > 
> > > > Excellent point, thank you!
> > > > 
> > > > I hope that this makes Mirsad's life easier, perhaps featuring less time
> > > > waiting for kernel builds and reboots.  ;-)
> > > 
> > > Unfortunately, the first stall and NMI occurs before any system script or setting a /sys/module/rcupdate/parameters/*
> > > could be executed, as second 14 of the boot process:
> > > 
> > > [   14.320045] rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { 7-.... } 6 jiffies s: 105 root: 0x80/.
> > > [   14.320064] rcu: blocking rcu_node structures (internal RCU debug):
> 
> ...
> 
> > > Probably something sensible should be set in the case of KASAN build. This example of stall
> > > apparently has nothing to do with squashfs_readahead().
> > 
> > Can't have everything, I guess!
> > 
> > How about building your kernel with CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=200?
> > Again, mainline defaults to 21000.
> 
> Did just that, and so far there is no modprobe stall in second 14 of boot at least. Looks good.
> Probably it is too early to say anything in general before more uptime and stress load.
> 
> BTW, the 20 for CONFIG_RCU_EXP_STALL_TIMEOUT wasn't my invention, but it comes from generic
> Ubuntu stock kernel (but without KASAN or KMEMLEAK config options):
> 
> # grep STALL /boot/config-5.19.5-051905-generic
> CONFIG_RCU_STALL_COMMON=y
> # CONFIG_HEADERS_INSTALL is not set
> CONFIG_RCU_CPU_STALL_TIMEOUT=60
> CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=20
> #

Gotta admit, those Ubuntu folks do not lack for bravery!!!  Even if they
don't also enable KASAN or KMEMLEAK by default.  ;-)

							Thanx, Paul

  parent reply	other threads:[~2022-11-24 20:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 19:21 RCU stalls in squashfs_readahead() Mirsad Goran Todorovac
2022-11-17 23:05 ` BUG: in squashfs_xz_uncompress() (Was: RCU stalls in squashfs_readahead()) Mirsad Goran Todorovac
2022-11-17 23:40   ` Mirsad Goran Todorovac
2022-11-18  6:11   ` Phillip Lougher
2022-11-18 15:17     ` Mirsad Goran Todorovac
2022-11-18 15:55     ` Paul E. McKenney
2022-11-20 15:49       ` BUG: BISECTED: " Mirsad Goran Todorovac
2022-11-20 17:50         ` Paul E. McKenney
2022-11-20 18:36           ` Mirsad Goran Todorovac
2022-11-20 19:21             ` Paul E. McKenney
2022-11-21  4:04               ` Mirsad Goran Todorovac
2022-11-22  2:07                 ` Paul E. McKenney
2022-11-23  9:14                   ` Mirsad Goran Todorovac
2022-11-23 14:44                     ` Paul E. McKenney
2022-11-23 16:08                       ` Elliott, Robert (Servers)
2022-11-23 19:09                         ` Paul E. McKenney
2022-11-24 17:06                           ` Mirsad Goran Todorovac
2022-11-24 17:19                             ` Paul E. McKenney
2022-11-24 18:04                               ` Mirsad Goran Todorovac
2022-11-24 19:32                                 ` Phillip Lougher
2022-12-06 20:35                                   ` Mirsad Goran Todorovac
2022-11-24 20:15                                 ` Paul E. McKenney [this message]
2022-11-20 19:33             ` Mirsad Goran Todorovac
2022-11-18 16:51     ` BUG: " Elliott, Robert (Servers)
2022-12-20 10:43       ` Mirsad Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124201552.GV4001@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=elliott@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=phillip.lougher@gmail.com \
    --cc=phillip@squashfs.org.uk \
    --cc=regressions@leemhuis.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®