Hi Lino, I love your patch! Perhaps something to improve: [auto build test WARNING on 30a0b95b1335e12efef89dd78518ed3e4a71a763] url: https://github.com/intel-lab-lkp/linux/commits/Lino-Sanfilippo/TPM-IRQ-fixes/20221124-215932 base: 30a0b95b1335e12efef89dd78518ed3e4a71a763 patch link: https://lore.kernel.org/r/20221124135538.31020-6-LinoSanfilippo%40gmx.de patch subject: [PATCH v11 05/14] tpm, tpm_tis: Claim locality before writing interrupt registers config: m68k-allyesconfig compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/aff4f2aead15a8dd374e43112b120603e7008156 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Lino-Sanfilippo/TPM-IRQ-fixes/20221124-215932 git checkout aff4f2aead15a8dd374e43112b120603e7008156 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/char/tpm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_gen_interrupt': >> drivers/char/tpm/tpm_tis_core.c:737:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 737 | int ret; | ^~~ vim +/ret +737 drivers/char/tpm/tpm_tis_core.c 41a5e1cf1fe151 Christophe Ricard 2016-05-19 731 c80ceaa1aa1671 Lino Sanfilippo 2022-11-24 732 static void tpm_tis_gen_interrupt(struct tpm_chip *chip) eb5854e764b91a Jarkko Sakkinen 2016-06-12 733 { eb5854e764b91a Jarkko Sakkinen 2016-06-12 734 const char *desc = "attempting to generate an interrupt"; eb5854e764b91a Jarkko Sakkinen 2016-06-12 735 u32 cap2; eb5854e764b91a Jarkko Sakkinen 2016-06-12 736 cap_t cap; d53a6adfb55396 Lukasz Majczak 2021-02-16 @737 int ret; eb5854e764b91a Jarkko Sakkinen 2016-06-12 738 e630af7dfb450d Jarkko Sakkinen 2021-05-10 739 if (chip->flags & TPM_CHIP_FLAG_TPM2) e630af7dfb450d Jarkko Sakkinen 2021-05-10 740 ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc); e630af7dfb450d Jarkko Sakkinen 2021-05-10 741 else d53a6adfb55396 Lukasz Majczak 2021-02-16 742 ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, 0); eb5854e764b91a Jarkko Sakkinen 2016-06-12 743 } eb5854e764b91a Jarkko Sakkinen 2016-06-12 744 -- 0-DAY CI Kernel Test Service https://01.org/lkp