From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845F6C43219 for ; Fri, 25 Nov 2022 16:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbiKYQEC (ORCPT ); Fri, 25 Nov 2022 11:04:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiKYQEA (ORCPT ); Fri, 25 Nov 2022 11:04:00 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917334C246; Fri, 25 Nov 2022 08:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669392239; x=1700928239; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ogMIFJsSPtXr34UU0OZ654UJ+S1J3B2EduR1CCJaTuc=; b=TA+UQAqYzgUcXoGVLcFjQ58VIvYLKrd+PpdpAOHGml7gbiuB6lH7u7cH Fu1DD+znE7pSHNEf7GWqFZePQ42dEjOQuEiB6lCEjxDQBQbizduPlCnUY //EjiNGiBs/58gvmH+81dKVGVvW5pVXIKpCjqd+K1nK1L0nVcJES2UnVe nAMBykF55znd4yrupiRmOnHCrgG2ccvNYI5bVQPnb03XMB5rWCIXAVNEq VFnBouAETBWWkbdpUg0bG5aG+h0R7ZQJt1LJi9JZEEEfTP8ZtHB2ToT/d qBXYE52Ibt3p2Jx7pdsVaXbir+rnDGMod4ETWdjlbw7Yaz+TKIEE5y7WR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10542"; a="400794754" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="400794754" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2022 08:01:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10542"; a="784975819" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="784975819" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by fmsmga001.fm.intel.com with ESMTP; 25 Nov 2022 08:01:53 -0800 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 2APG1pIt005314; Fri, 25 Nov 2022 16:01:51 GMT From: Alexander Lobakin To: "Goh, Wei Sheng" Cc: Alexander Lobakin , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Torgue , Ong Boon Leong , Voon Wei Feng , Tan Tee Min , Ahmad Tarmizi Noor Azura , Looi Hong Aun Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings Date: Fri, 25 Nov 2022 17:01:35 +0100 Message-Id: <20221125160135.83994-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221123105110.23617-1-wei.sheng.goh@intel.com> References: <20221123105110.23617-1-wei.sheng.goh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Goh, Wei Sheng" Date: Wed, 23 Nov 2022 18:51:10 +0800 > Currently, pause frame register GMAC_RX_FLOW_CTRL_RFE is not updated > correctly when 'ethtool -A autoneg off rx off tx off' command > is issued. This fix ensures the flow control change is reflected directly > in the GMAC_RX_FLOW_CTRL_RFE register. Any particular reason why you completely ignored by review comments to the v3[0]? I'd like to see them fixed or at least replied. > > Fixes: 46f69ded988d ("net: stmmac: Use resolved link config in mac_link_up()") > Cc: # 5.10.x > Signed-off-by: Goh, Wei Sheng > Signed-off-by: Noor Azura Ahmad Tarmizi > --- > V3 -> V4: Fix commit message and incorrect insertions(+) value > V2 -> V3: Removed value assign for 'flow' in else statement based on review comments > V1 -> V2: Removed needless condition based on review comments > > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++++++-- > 2 files changed, 12 insertions(+), 2 deletions(-) [...] > -- > 2.17.1 [0] https://lore.kernel.org/netdev/20221123180947.488302-1-alexandr.lobakin@intel.com Thanks, Olek