From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DA2C43217 for ; Sat, 26 Nov 2022 12:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbiKZM5l (ORCPT ); Sat, 26 Nov 2022 07:57:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbiKZM5i (ORCPT ); Sat, 26 Nov 2022 07:57:38 -0500 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D074F00C for ; Sat, 26 Nov 2022 04:57:35 -0800 (PST) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 2AQCuhbq014203-2AQCuhbt014203 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sat, 26 Nov 2022 20:56:51 +0800 From: Dongliang Mu To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Dongliang Mu , Arnd Bergmann , Mingyi Kang Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add Date: Sat, 26 Nov 2022 20:56:33 +0800 Message-Id: <20221126125642.16358-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smatch reports the following issue: drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add() warn: '&entry->list' not removed from list Fix this by adding list_del in the error handling code. Signed-off-by: Dongliang Mu --- drivers/staging/vme_user/vme_tsi148.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c index 020e0b3bce64..0171f46d1848 100644 --- a/drivers/staging/vme_user/vme_tsi148.c +++ b/drivers/staging/vme_user/vme_tsi148.c @@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list, return 0; err_dma: + list_del(&entry->list); err_dest: err_source: err_align: -- 2.37.1 (Apple Git-137.1)