From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CFAC43217 for ; Mon, 28 Nov 2022 22:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233992AbiK1W3L (ORCPT ); Mon, 28 Nov 2022 17:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232683AbiK1W3I (ORCPT ); Mon, 28 Nov 2022 17:29:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF5B24B; Mon, 28 Nov 2022 14:29:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CB78614AE; Mon, 28 Nov 2022 22:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7452CC433D6; Mon, 28 Nov 2022 22:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669674546; bh=xcQxXnrPCAnUx0UIMRQ0AyINld9piSgUJcX2QXwJ60M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EoqthV20Y+l4UTWI1AZtrRV93JG3GOnbQKy2tYKNI12ewckkMKp+2P/Cm8MeGeH2G ROHIqS+lMvigJpRr/gPxtQ+kfdmGpcXXNEJE3M6LqhodE2bsF6noOk+AR9iryZxG5c bxcitNTGsr2z8yoXyxBv6+1ovCAqAJnk14s/wucUjVtH0uc1+2Y3K8CykaUib6YVjH 7Oizk9UGfSwou8kEYjTYF4C+8JG3PZ4f/QUl6s1iRQOD6Vpy0vHhjHUtJE5i4NRj1z nzhI473FyyEKF+jOfUg4uLh3FLJAOxGolaSIs4uBDJeCT3+r4dNFI90DvNGCnekYK4 ci98NqGWiIQuw== Date: Mon, 28 Nov 2022 14:29:05 -0800 From: Jakub Kicinski To: Vincent Mailhol Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Saeed Mahameed , Andrew Lunn , Jiri Pirko , Lukas Magel Subject: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool Message-ID: <20221128142857.07cb5d88@kicinski-fedora-PC1C0HJN> In-Reply-To: <20221126162211.93322-6-mailhol.vincent@wanadoo.fr> References: <20221104073659.414147-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-6-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 27 Nov 2022 01:22:10 +0900 Vincent Mailhol wrote: > Implement ethtool_ops::get_drvinfo() in order to report the firmware > version. > > Firmware version 0.0.0 has a special meaning and just means that we > could not parse the product information string. In such case, do > nothing (i.e. leave the .fw_version string empty). devlink_compat_running_version() does not work?