From: Steven Rostedt <rostedt@goodmis.org>
To: <zhang.songyi@zte.com.cn>
Cc: <zhangqing@loongson.cn>, <chenhuacai@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH linux-next] recordmcount: use "!P" instead of "P == 0"
Date: Wed, 30 Nov 2022 09:05:30 -0500 [thread overview]
Message-ID: <20221130090530.3e7ec88e@gandalf.local.home> (raw)
In-Reply-To: <202211301547353578204@zte.com.cn>
On Wed, 30 Nov 2022 15:47:35 +0800 (CST)
<zhang.songyi@zte.com.cn> wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> comparing pointer to 0, use !P instead of it.
Both are correct. No need for useless churn like this.
-- Steve
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> scripts/recordmcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index cce12e1971d8..8d01decd12e9 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
> static void * umalloc(size_t size)
> {
> void *const addr = malloc(size);
> - if (addr == 0) {
> + if (!addr) {
> fprintf(stderr, "malloc failed: %zu bytes\n", size);
> file_append_cleanup();
> mmap_cleanup();
> --
> 2.15.2
prev parent reply other threads:[~2022-11-30 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 7:47 zhang.songyi
2022-11-30 14:05 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130090530.3e7ec88e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhang.songyi@zte.com.cn \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®