From: Yair Podemsky <ypodemsk@redhat.com>
To: peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
rafael.j.wysocki@intel.com, ggherdovich@suse.cz,
jlelli@redhat.com, mtosatti@redhat.com, nsaenz@kernel.org,
linux-kernel@vger.kernel.org
Cc: ypodemsk@redhat.com
Subject: [PATCH] sched/core: Fix arch_scale_freq_tick() on tickless systems
Date: Wed, 30 Nov 2022 14:51:21 +0200 [thread overview]
Message-ID: <20221130125121.34407-1-ypodemsk@redhat.com> (raw)
In order for the scheduler to be frequency invariant we measure the
ratio between the maximum cpu frequency and the actual cpu frequency.
During long tickless periods of time the calculations that keep track
of that might overflow, in the function scale_freq_tick():
if (check_shl_overflow(acnt, 2*SCHED_CAPACITY_SHIFT, &acnt))
» goto error;
eventually forcing the kernel to disable the feature for all cpus,
and show the warning message
"Scheduler frequency invariance went wobbly, disabling!".
Let's avoid that by limiting the frequency invariant calculations
to cpus with regular tick.
Fixes: e2b0d619b400 ("x86, sched: check for counters overflow in frequency invariant accounting")
Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
Suggested-by: "Peter Zijlstra (Intel)" <peterz@infradead.org>
---
V1 -> V2: solution approach was changed from detecting long tickless periods
to frequency invariant measurements on housekeeping cpus only.
Link: ee89073a1e9de11c7bd7726eb5da71a0e8795099.camel@redhat.com
---
kernel/sched/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index daff72f00385..1bb0a840c817 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5469,7 +5469,9 @@ void scheduler_tick(void)
unsigned long thermal_pressure;
u64 resched_latency;
- arch_scale_freq_tick();
+ if (housekeeping_cpu(cpu, HK_TYPE_TICK))
+ arch_scale_freq_tick();
+
sched_clock_tick();
rq_lock(rq, &rf);
--
2.31.1
next reply other threads:[~2022-11-30 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 12:51 Yair Podemsky [this message]
2022-12-14 9:49 ` Valentin Schneider
2022-12-14 15:35 ` Giovanni Gherdovich
2023-01-04 15:47 ` ypodemsk
2023-01-07 11:36 ` [tip: sched/urgent] " tip-bot2 for Yair Podemsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130125121.34407-1-ypodemsk@redhat.com \
--to=ypodemsk@redhat.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ggherdovich@suse.cz \
--cc=jlelli@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nsaenz@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®