From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12969C43217 for ; Thu, 1 Dec 2022 16:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbiLAQtM (ORCPT ); Thu, 1 Dec 2022 11:49:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiLAQs4 (ORCPT ); Thu, 1 Dec 2022 11:48:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 134411DDCB for ; Thu, 1 Dec 2022 08:48:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD1F1B81F96 for ; Thu, 1 Dec 2022 16:48:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF7F8C433C1; Thu, 1 Dec 2022 16:48:50 +0000 (UTC) Date: Thu, 1 Dec 2022 11:48:48 -0500 From: Steven Rostedt To: Kees Cook Cc: "Masami Hiramatsu (Google)" , LKML , Borislav Petkov , Alexei Starovoitov , Linus Torvalds , Andrew Morton , Peter Zijlstra , Josh Poimboeuf , KP Singh , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig , Chris Mason Subject: Re: [RFC PATCH] panic: Add new taint flag for fault injection Message-ID: <20221201114848.13a87aca@gandalf.local.home> In-Reply-To: <202212010838.B0B109DA@keescook> References: <20221201234121.8925fdf83115747ac4ac116a@kernel.org> <166991263326.311919.16890937584677289681.stgit@devnote3> <202212010838.B0B109DA@keescook> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Dec 2022 08:39:28 -0800 Kees Cook wrote: > On Fri, Dec 02, 2022 at 01:37:13AM +0900, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) > > > > Since the function error injection framework in the fault injection > > subsystem can change the function code flow forcibly, it may cause > > unexpected behavior (but that is the purpose of this feature). > > To identify this in the kernel oops message, add a new taint flag > > for this, and set it if it is (and similar things in BPF) used. > > Why is hooking through BPF considered to be "fault injection" here? > Have you not been reading this thread? -- Steve