From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E65EC4332F for ; Fri, 2 Dec 2022 01:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231154AbiLBBdH (ORCPT ); Thu, 1 Dec 2022 20:33:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiLBBdE (ORCPT ); Thu, 1 Dec 2022 20:33:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6AAEC3FC6 for ; Thu, 1 Dec 2022 17:33:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2970EB81FBE for ; Fri, 2 Dec 2022 01:33:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E01B4C433D6; Fri, 2 Dec 2022 01:32:58 +0000 (UTC) Date: Thu, 1 Dec 2022 20:32:57 -0500 From: Steven Rostedt To: Jiri Kosina Cc: Linus Torvalds , Alexei Starovoitov , Andrew Morton , Chris Mason , Borislav Petkov , LKML , Masami Hiramatsu , Peter Zijlstra , Kees Cook , Josh Poimboeuf , KP Singh , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig , Benjamin Tissoires Subject: Re: [PATCH] error-injection: Add prompt for function error injection Message-ID: <20221201203257.6fa19473@gandalf.local.home> In-Reply-To: References: <20221121104403.1545f9b5@gandalf.local.home> <3fa8ec60-dd96-c41f-ea46-8856bf855949@meta.com> <20221122132905.12a8d5ad@gandalf.local.home> <20221130143719.07e36277d1471b83e9a1b627@linux-foundation.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Dec 2022 02:03:03 +0100 (CET) Jiri Kosina wrote: > On Thu, 1 Dec 2022, Linus Torvalds wrote: > > > > Anyway, I believe [1] that ERROR_INJECTION has been designed as a > > > debugging feature in the first place, and should stay so. After figuring > > > out now that HID-BPF actually has hard dependence on it, I fully agree [2] > > > that the series should be ditched for 6.2 and will work with Benjamin to > > > have it removed from current hid.git#for-next. > > > > I do think that it is interesting to have a "let's have a bpf > > insertion hook here", so I'm not against the _concept_ of HID doing > > that. > > Absolutely, me neither, quite the contrary -- I am quite happy to see > HID-BPF happening, because it'll actually make life easier for everybody: > for people with quirky hardware (trivial testing of fixes), for kernel > developers (trivial testing of fixes), and for distributions (trivial > distribution of fixes). Full disclosure, I'm not against a bpf_hook either. In fact, I think I even stated something to that effect, like adding a bpf_hook annotation to functions or whatever, so that people can plainly see that the function can have bpf attached to it. I just *hate* the ad hoc way of using infrastructure for other purposes than what they were designed for. -- Steve