From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Aditya Garg <gargaditya08@live.com>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes
Date: Fri, 2 Dec 2022 13:10:29 -0800 [thread overview]
Message-ID: <20221202131029.50fde1c15a2dd7e156f7e1e8@linux-foundation.org> (raw)
In-Reply-To: <Y4pnuBnoHvIS8UB6@casper.infradead.org>
On Fri, 2 Dec 2022 21:01:44 +0000 Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Dec 02, 2022 at 12:53:44PM -0800, Andrew Morton wrote:
> > > + if (force_journaled_rw) {
> > > + pr_warn("write access to a journaled filesystem is not supported, but has been force enabled.\n");
> > > + } else {
> > > + pr_warn("write access to a journaled filesystem is not supported, use the force option at your own risk, mounting read-only.\n");
> > > + sb->s_flags |= SB_RDONLY;
> > > + }
> >
> > All these super long lines are an eyesore. How about
> >
> > pr_warn("write access to a journaled filesystem is "
> > "not supported, but has been force enabled.\n");
>
> Linus has asked us to not do that because it makes it hard to grep.
Yup. But as with everything, there are tradeoffs. These messages are
so messy to read and reading code is more common than grepping for
error messages. Just grep the first 20-30 characters...
next prev parent reply other threads:[~2022-12-02 21:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 6:01 Aditya Garg
2022-12-02 20:38 ` Viacheslav Dubeyko
2022-12-02 20:53 ` Andrew Morton
2022-12-02 21:01 ` Matthew Wilcox
2022-12-02 21:10 ` Andrew Morton [this message]
2022-12-03 6:22 ` Aditya Garg
2022-12-04 8:07 ` Christoph Hellwig
2022-12-04 11:01 ` Aditya Garg
2022-12-06 8:52 ` Christoph Hellwig
2022-12-03 7:11 ` [PATCH v2] " Aditya Garg
2022-12-04 1:05 ` kernel test robot
2022-12-04 6:43 ` Aditya Garg
2022-12-06 15:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202131029.50fde1c15a2dd7e156f7e1e8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gargaditya08@live.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®