mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bart Groeneveld | GPX Solutions B.V" <bart@gpxbv.nl>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Bart Groeneveld | GPX Solutions B.V." <bart@gpxbv.nl>
Subject: [PATCH] acpi: allow usage of acpi_tad without PRW
Date: Fri,  2 Dec 2022 16:34:55 +0100	[thread overview]
Message-ID: <20221202153454.83185-1-bart@gpxbv.nl> (raw)

From: "Bart Groeneveld | GPX Solutions B.V." <bart@gpxbv.nl>

Not all tads have the PRW capability, which is totally OK,
according to the ACPI spec [1]:

> _PRW is only required for devices that have the ability to wake
> the system from a system sleeping state.

This partially solves [2] and [3].

[1]: https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf
[2]: https://bugzilla.kernel.org/show_bug.cgi?id=212313
[3]: https://github.com/linux-surface/linux-surface/issues/415

Signed-off-by: Bart Groeneveld | GPX Solutions B.V. <bart@gpxbv.nl>
---
 drivers/acpi/acpi_tad.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/acpi/acpi_tad.c b/drivers/acpi/acpi_tad.c
index e9b8e8305e23..67f71fa4362f 100644
--- a/drivers/acpi/acpi_tad.c
+++ b/drivers/acpi/acpi_tad.c
@@ -604,11 +604,6 @@ static int acpi_tad_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	if (!acpi_has_method(handle, "_PRW")) {
-		dev_info(dev, "Missing _PRW\n");
-		return -ENODEV;
-	}
-
 	dd = devm_kzalloc(dev, sizeof(*dd), GFP_KERNEL);
 	if (!dd)
 		return -ENOMEM;
-- 
2.38.1


             reply	other threads:[~2022-12-02 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 15:34 Bart Groeneveld | GPX Solutions B.V [this message]
2022-12-02 18:04 ` Rafael J. Wysocki
2022-12-05 15:08   ` [PATCH v2] acpi: allow usage of acpi_tad on HW-reduced platforms Bart Groeneveld | GPX Solutions B.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221202153454.83185-1-bart@gpxbv.nl \
    --to=bart@gpxbv.nl \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®