Hi Elliot, I love your patch! Yet something to improve: [auto build test ERROR on 094226ad94f471a9f19e8f8e7140a09c2625abaa] url: https://github.com/intel-lab-lkp/linux/commits/Elliot-Berman/Drivers-for-gunyah-hypervisor/20221121-220942 base: 094226ad94f471a9f19e8f8e7140a09c2625abaa patch link: https://lore.kernel.org/r/20221121140009.2353512-20-quic_eberman%40quicinc.com patch subject: [PATCH v7 19/20] firmware: qcom_scm: Register Gunyah platform ops config: m68k-randconfig-m041-20221201 compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e7c817504febf0e6f3171fe49429d117c4ec7bec git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Elliot-Berman/Drivers-for-gunyah-hypervisor/20221121-220942 git checkout e7c817504febf0e6f3171fe49429d117c4ec7bec # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/virt/gunyah/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/virt/gunyah/gunyah_platform_hooks.c:39:5: error: redefinition of 'gh_rm_register_platform_ops' 39 | int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/virt/gunyah/gunyah_platform_hooks.c:8: include/linux/gunyah_rsc_mgr.h:132:19: note: previous definition of 'gh_rm_register_platform_ops' with type 'int(struct gunyah_rm_platform_ops *)' 132 | static inline int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/virt/gunyah/gunyah_platform_hooks.c:53:6: error: redefinition of 'gh_rm_unregister_platform_ops' 53 | void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/gunyah_rsc_mgr.h:134:20: note: previous definition of 'gh_rm_unregister_platform_ops' with type 'void(struct gunyah_rm_platform_ops *)' 134 | static inline void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/gh_rm_register_platform_ops +39 drivers/virt/gunyah/gunyah_platform_hooks.c 732a90ac408a53 Elliot Berman 2022-11-21 38 732a90ac408a53 Elliot Berman 2022-11-21 @39 int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops) 732a90ac408a53 Elliot Berman 2022-11-21 40 { 732a90ac408a53 Elliot Berman 2022-11-21 41 int ret = 0; 732a90ac408a53 Elliot Berman 2022-11-21 42 732a90ac408a53 Elliot Berman 2022-11-21 43 down_write(&rm_platform_ops_lock); 732a90ac408a53 Elliot Berman 2022-11-21 44 if (!rm_platform_ops) 732a90ac408a53 Elliot Berman 2022-11-21 45 rm_platform_ops = platform_ops; 732a90ac408a53 Elliot Berman 2022-11-21 46 else 732a90ac408a53 Elliot Berman 2022-11-21 47 ret = -EEXIST; 732a90ac408a53 Elliot Berman 2022-11-21 48 up_write(&rm_platform_ops_lock); 732a90ac408a53 Elliot Berman 2022-11-21 49 return ret; 732a90ac408a53 Elliot Berman 2022-11-21 50 } 732a90ac408a53 Elliot Berman 2022-11-21 51 EXPORT_SYMBOL_GPL(gh_rm_register_platform_ops); 732a90ac408a53 Elliot Berman 2022-11-21 52 732a90ac408a53 Elliot Berman 2022-11-21 @53 void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops) 732a90ac408a53 Elliot Berman 2022-11-21 54 { 732a90ac408a53 Elliot Berman 2022-11-21 55 down_write(&rm_platform_ops_lock); 732a90ac408a53 Elliot Berman 2022-11-21 56 if (rm_platform_ops == platform_ops) 732a90ac408a53 Elliot Berman 2022-11-21 57 rm_platform_ops = NULL; 732a90ac408a53 Elliot Berman 2022-11-21 58 up_write(&rm_platform_ops_lock); 732a90ac408a53 Elliot Berman 2022-11-21 59 } 732a90ac408a53 Elliot Berman 2022-11-21 60 EXPORT_SYMBOL_GPL(gh_rm_unregister_platform_ops); 732a90ac408a53 Elliot Berman 2022-11-21 61 -- 0-DAY CI Kernel Test Service https://01.org/lkp