From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D29C4332F for ; Sat, 3 Dec 2022 23:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbiLCXL2 (ORCPT ); Sat, 3 Dec 2022 18:11:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiLCXLZ (ORCPT ); Sat, 3 Dec 2022 18:11:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC7491DF21 for ; Sat, 3 Dec 2022 15:11:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 821D860C63 for ; Sat, 3 Dec 2022 23:11:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0C39C433C1; Sat, 3 Dec 2022 23:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670109082; bh=fjYBvAES6yIz6ALuP3bde3A5XBDR/QJ5b8TsiwS2rCM=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=OiR7chEYhQoOwM7m689fswTWF/LlrnQfZy4b7m15JJh8UePAhhAvE5ggQ97bNt+ls ZhFfIfsLIWpbrJYSyjDYt0qiEBP+e4CK/qcgf3U7LMhnk+eFoUyxjHjHDdUshKsyLK B7UrEVd9E49llgcpLMsw3Hk41i5AetPy5nbBGuYsv5QJXnycmXh2nAYEor5I6rY2+d jvBPZUkz/agzMQYLpJJttzoAi0AkXiuDIXxsO8l3Wf7JAxBkk/WJvzJlV9rV7rX9r4 vai3vH9R9nPf0vi/urVko2SaQ2a3idU5C5JXHnQ7Z+caEDhWY1CSRl/01OiL39eVZh spuQ91Pj3lGYw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 6AAB15C146D; Sat, 3 Dec 2022 15:11:22 -0800 (PST) Date: Sat, 3 Dec 2022 15:11:22 -0800 From: "Paul E. McKenney" To: "stern@rowland.harvard.edu" Cc: Jonas Oberhauser , Boqun Feng , "parri.andrea@gmail.com" , "will@kernel.org" , "peterz@infradead.org" , "npiggin@gmail.com" , "dhowells@redhat.com" , "j.alglave@ucl.ac.uk" , "luc.maranget@inria.fr" , "akiyks@gmail.com" , "dlustig@nvidia.com" , "joel@joelfernandes.org" , "urezki@gmail.com" , "quic_neeraju@quicinc.com" , "frederic@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] tools: memory-model: Make plain accesses carry dependencies Message-ID: <20221203231122.GZ4001@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20221202125100.30146-1-jonas.oberhauser@huaweicloud.com> <4262e55407294a5989e766bc4dc48293@huawei.com> <20221203190226.GR4001@paulmck-ThinkPad-P17-Gen-1> <20221203204405.GW4001@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 03, 2022 at 04:32:19PM -0500, stern@rowland.harvard.edu wrote: > On Sat, Dec 03, 2022 at 12:44:05PM -0800, Paul E. McKenney wrote: > > On Sat, Dec 03, 2022 at 03:34:20PM -0500, stern@rowland.harvard.edu wrote: > > > On Sat, Dec 03, 2022 at 11:02:26AM -0800, Paul E. McKenney wrote: > > > > On Sat, Dec 03, 2022 at 11:58:36AM +0000, Jonas Oberhauser wrote: > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Boqun Feng [mailto:boqun.feng@gmail.com] > > > > > Sent: Friday, December 2, 2022 7:50 PM > > > > > > > > > > I wonder is this patch a first step to solve the OOTA problem you reported in OSS: > > > > > > https://static.sched.com/hosted_files/osseu2022/e1/oss-eu22-jonas.pdf > > > > > > If so maybe it's better to put the link in the commit log I think. > > > > > > > > > > It's not directly related to that specific problem, it does solve some other OOTA issues though. > > > > > If you think we should link to the talk, there's also a video with slightly more updated slides from the actual talk: https://www.youtube.com/watch?v=iFDKhIxKhoQ > > > > > do you think I should link to both then? > > > > > > > > It is not hard for me to add that in if people believe that it should be > > > > included. But default is lazy in this case. ;-) > > > > > > I don't think there's any need to mention that video in the commit log. > > > It's an introductory talk, and it's pretty safe to assume that anyone > > > reading the commit because they are interested in the LKMM in great > > > detail is already beyond the introductory level. > > > > > > On the other hand, it wouldn't hurt to include a Link: tag to an > > > appropriate message in this email thread. (I leave it up to Paul to > > > decide which message is most "appropriate" -- there may not be a good > > > candidate, because a lot of the messages were not CC'ed to LKML.) > > > > For this approach, I would add this: > > > > Link: https://lore.kernel.org/all/4262e55407294a5989e766bc4dc48293@huawei.com/ > > There's no point including that link; it merely points to messages > containing or commenting on early versions of the commit. It adds very > little information not already present in the commit itself. (Have you > read any of Linus's criticisms of the Link: tags that people tend to > include in patches they send him? It's the same principle.) > > I was thinking of the discussion which led up to the commit being > written, where Jonas first brought up the idea that plain accesses > should be able to carry dependencies just like accesses to registers. > That's the sort of thing which would give readers some context and > understanding of the reasoning behind the commit. They were part of the > thread with the subject "RE: Interesting LKMM litmus test". > > But I can't find those messages on lore.kernel.org (which isn't > surprising, as they weren't CC'ed to any mailing lists). I am OK with them being made public, maybe in a Google document or some such. We would of course also need the consent of everyone else on that thread. > > I could of course do both the extra paragraph -and- the Link:. ;-) > > > > Thoughts? > > My advice: Omit them both. It would be good to reference something or another. ;-) Thanx, Paul