mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
	<mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Shravan Chippa" <shravan.chippa@microchip.com>
Subject: [PATCH v6 1/5] media: i2c: imx334: modify link frequency as for the configureation
Date: Mon, 5 Dec 2022 10:49:32 +0530	[thread overview]
Message-ID: <20221205051937.3897001-2-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20221205051937.3897001-1-shravan.chippa@microchip.com>

From: Shravan Chippa <shravan.chippa@microchip.com>

Currently imx334 sensor driver is configured for 1782Mbps/lane for
3840x2160@60 resolution with reqired reg mode values but if we run the
command "v4l2-ctl --all -d /dev/v4l-subdevX" it is showing incorrect link
frequeny, This is because of the incorrect value of IMX334_LINK_FREQ
witch is 891000000. it should be 1782000000.

In general with the value of 891000000 link frequency it is not possible
to configure 3840x2160@60 resolution.

Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver")

Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
 drivers/media/i2c/imx334.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 7b0a9086447d..acc9f9f15e47 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -49,7 +49,7 @@
 #define IMX334_INCLK_RATE	24000000
 
 /* CSI2 HW configuration */
-#define IMX334_LINK_FREQ	891000000
+#define IMX334_LINK_FREQ	1782000000
 #define IMX334_NUM_DATA_LANES	4
 
 #define IMX334_REG_MIN		0x00
-- 
2.34.1


  reply	other threads:[~2022-12-05  5:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05  5:19 [PATCH v6 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-05  5:19 ` shravan kumar [this message]
2022-12-05  5:19 ` [PATCH v6 2/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range shravan kumar
2022-12-05  5:19 ` [PATCH v6 3/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2022-12-05  5:19 ` [PATCH v6 3/5] media: i2c: imx334: add missing reset values for mode_3840x2160_regs[] shravan kumar
2022-12-05  5:19 ` [PATCH v6 4/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-05  9:11   ` kernel test robot
2022-12-05 12:38   ` kernel test robot
2022-12-05  5:19 ` [PATCH v6 5/5] media: i2c: imx334: update pixel and link frequency shravan kumar
2022-12-12 11:31 ` [PATCH v6 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205051937.3897001-2-shravan.chippa@microchip.com \
    --to=shravan.chippa@microchip.com \
    --cc=daniele.alessandrelli@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®