From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83592C4332F for ; Mon, 5 Dec 2022 19:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233907AbiLETY5 (ORCPT ); Mon, 5 Dec 2022 14:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233571AbiLETYY (ORCPT ); Mon, 5 Dec 2022 14:24:24 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200722BB18 for ; Mon, 5 Dec 2022 11:19:44 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id vp12so876743ejc.8 for ; Mon, 05 Dec 2022 11:19:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DPKbqc0ak5V4UJgzOj7j3ooXS6vGnBnkbq2OKYA/WT4=; b=DIi5u4t6g9JgH5XoC4drvV8Izbr9aVvc4hCrSjc3S11Chs7ShVAECZJ3qrDFTtPPgm lahrxw56tiHndSBVtvsjtLuoMulsicVgzsL8jREK7k9JDx2V4JG33oiU1ofiL/UP2LEz hi8RWX4EN7Zn3KtA96dd+6jOVMPvCmKiwDTyQBGhkdK1sm2it8wjSaCxnS7vRe7t51dK dqUj0HCRP8J6NUaCfEPORe+xiEAOVaCXBISAQVZnO8Y6SZHfGQdESr9mhtEUWC5N3J+d CZuX/KprWZPIw1p9v0BDB+dS05zvKq5BDw002KAPZCM1EbyexUSmnAfpxFuLdC917PoG KC4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPKbqc0ak5V4UJgzOj7j3ooXS6vGnBnkbq2OKYA/WT4=; b=3vAIH9rUQSeHAiTPcjq2o5cPEYW6op0wPSz7VtpmrGK4rHbh7z17A8F2LmKuXvDdDs GpLd44Ys+WAFXbimBlr3heCZ95UMS86jxm57ULlpKxVijXLk1yf35akxcN3eXRX75Htw WQuxgS+vDRgcXzIw+lyew7DeaEOEsTLogORrOWWNNnbt0MKv+1bhWaYpQ6sscCohxo9B q9SMZ8wjVUTiKnq/ivGOAlTtl8I6ROrdxpmmzhGTBqrnysUGUo4MQ9l5ywcZKc8gLGnh Rbh6+ZPca4t7gDJy/jtbr/XEBK/smXuwwn/V+AsflK4XJdfZY9mJjGYgEB3REndiCEzU BVBQ== X-Gm-Message-State: ANoB5pkLakDONpi8XSURebMl3zWHLxyB05iZHxOKVm8fko3pkqPIShGS HmIwidjsBR9LCeQIcs+RoDN6wA== X-Google-Smtp-Source: AA0mqf7u7VnY3Ni45y0AxJmuFN08d/uOHDX0qADbA2dYsG9Zjl6nCXFSiG0DUzYmpaNDKZK/7vTPJQ== X-Received: by 2002:a17:906:7852:b0:7b7:718d:22c with SMTP id p18-20020a170906785200b007b7718d022cmr56888823ejm.507.1670267982697; Mon, 05 Dec 2022 11:19:42 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id t16-20020aa7db10000000b0045cf4f72b04sm112739eds.94.2022.12.05.11.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 11:19:42 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v6 3/5] hwmon: (pmbus/core): Add rdev in pmbus_data struct Date: Mon, 5 Dec 2022 20:19:14 +0100 Message-Id: <20221205191917.2614603-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221205191917.2614603-1-Naresh.Solanki@9elements.com> References: <20221205191917.2614603-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add regulator device in pmbus_data & initialize the same during PMBus regulator register. Signed-off-by: Naresh Solanki --- Change in V5: - Fix error check for rdev --- drivers/hwmon/pmbus/pmbus_core.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index b005a1c8ad7e..afd98e639b4f 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -81,6 +81,7 @@ struct pmbus_label { struct pmbus_data { struct device *dev; struct device *hwmon_dev; + struct regulator_dev **rdevs; u32 flags; /* from platform data */ @@ -3095,9 +3096,13 @@ static int pmbus_regulator_register(struct pmbus_data *data) struct device *dev = data->dev; const struct pmbus_driver_info *info = data->info; const struct pmbus_platform_data *pdata = dev_get_platdata(dev); - struct regulator_dev *rdev; int i; + data->rdevs = devm_kzalloc(dev, sizeof(struct regulator_dev *) * info->num_regulators, + GFP_KERNEL); + if (!data->rdevs) + return -ENOMEM; + for (i = 0; i < info->num_regulators; i++) { struct regulator_config config = { }; @@ -3107,10 +3112,10 @@ static int pmbus_regulator_register(struct pmbus_data *data) if (pdata && pdata->reg_init_data) config.init_data = &pdata->reg_init_data[i]; - rdev = devm_regulator_register(dev, &info->reg_desc[i], + data->rdevs[i] = devm_regulator_register(dev, &info->reg_desc[i], &config); - if (IS_ERR(rdev)) - return dev_err_probe(dev, PTR_ERR(rdev), + if (IS_ERR(data->rdevs[i])) + return dev_err_probe(dev, PTR_ERR(data->rdevs[i]), "Failed to register %s regulator\n", info->reg_desc[i].name); } -- 2.37.3