From: Bjorn Andersson <andersson@kernel.org>
To: ye.xingchen@zte.com.cn
Cc: agross@kernel.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node()
Date: Mon, 5 Dec 2022 16:01:00 -0600 [thread overview]
Message-ID: <20221205220100.a2omqdmhtw26i7qx@builder.lan> (raw)
In-Reply-To: <202211171548066327249@zte.com.cn>
On Thu, Nov 17, 2022 at 03:48:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/soc/qcom/smem_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
> index e848cc9a3cf8..a7844841a727 100644
> --- a/drivers/soc/qcom/smem_state.c
> +++ b/drivers/soc/qcom/smem_state.c
> @@ -63,7 +63,7 @@ static struct qcom_smem_state *of_node_to_state(struct device_node *np)
> mutex_lock(&list_lock);
>
> list_for_each_entry(state, &smem_states, list) {
> - if (state->of_node == np) {
> + if (device_match_of_node(state, np)) {
I don't find this form easier to read, nor is state a struct device *...
Regards,
Bjorn
> kref_get(&state->refcount);
> goto unlock;
> }
> --
> 2.25.1
prev parent reply other threads:[~2022-12-05 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:48 ye.xingchen
2022-11-18 0:52 ` kernel test robot
2022-11-21 0:52 ` kernel test robot
2022-12-05 22:01 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205220100.a2omqdmhtw26i7qx@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®