From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH v2 3/6] ext4: remove unnessary size check in ext4_xattr_inode_get()
Date: Wed, 7 Dec 2022 15:40:40 +0800 [thread overview]
Message-ID: <20221207074043.1286731-4-yebin@huaweicloud.com> (raw)
In-Reply-To: <20221207074043.1286731-1-yebin@huaweicloud.com>
From: Ye Bin <yebin10@huawei.com>
As previous patch add check in ext4_xattr_check_entries(), before call
ext4_xattr_inode_get() will already do xattr entries check.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/ext4/xattr.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index eed001eee3ec..75287422c36c 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -525,14 +525,6 @@ ext4_xattr_inode_get(struct inode *inode, struct ext4_xattr_entry *entry,
goto out;
}
- if (i_size_read(ea_inode) != size) {
- ext4_warning_inode(ea_inode,
- "ea_inode file size=%llu entry size=%zu",
- i_size_read(ea_inode), size);
- err = -EFSCORRUPTED;
- goto out;
- }
-
err = ext4_xattr_inode_read(ea_inode, buffer, size);
if (err)
goto out;
--
2.31.1
next prev parent reply other threads:[~2022-12-07 7:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 7:40 [PATCH v2 0/6] Fix two issue about ext4 extended attribute Ye Bin
2022-12-07 7:40 ` [PATCH v2 1/6] ext4: fix WARNING in ext4_expand_extra_isize_ea Ye Bin
2022-12-07 7:51 ` Bagas Sanjaya
2022-12-07 7:40 ` [PATCH v2 2/6] ext4: add primary check extended attribute inode in ext4_xattr_check_entries() Ye Bin
2022-12-07 7:37 ` Bagas Sanjaya
2022-12-07 11:14 ` Jan Kara
2022-12-07 11:39 ` yebin (H)
2022-12-07 12:03 ` Jan Kara
2022-12-07 7:40 ` Ye Bin [this message]
2022-12-07 7:40 ` [PATCH v2 4/6] ext4: allocate extended attribute value in vmalloc area Ye Bin
2022-12-07 10:58 ` Jan Kara
2022-12-07 7:40 ` [PATCH v2 5/6] ext4: rename xattr_find_entry() and __xattr_check_inode() Ye Bin
2022-12-07 7:35 ` Bagas Sanjaya
2022-12-07 7:41 ` Bagas Sanjaya
2022-12-07 10:58 ` Jan Kara
2022-12-07 7:40 ` [PATCH v2 6/6] ext4: fix inode leak in 'ext4_xattr_inode_create()' Ye Bin
2022-12-07 7:44 ` Bagas Sanjaya
2022-12-07 11:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207074043.1286731-4-yebin@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®