mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH v3 2/4] ext4: allocate extended attribute value in vmalloc area
Date: Thu,  8 Dec 2022 10:32:31 +0800	[thread overview]
Message-ID: <20221208023233.1231330-3-yebin@huaweicloud.com> (raw)
In-Reply-To: <20221208023233.1231330-1-yebin@huaweicloud.com>

From: Ye Bin <yebin10@huawei.com>

Now, extended attribute value maximum length is 64K. The memory requested
here does not need continuous physical addresses, so it is appropriate to
use kvmalloc to request memory. At the same time, it can also cope with
the situation that the extended attribute will become longer in the future.

Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/xattr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 718ef3987f94..23cfefc6d262 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2556,7 +2556,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,
 
 	is = kzalloc(sizeof(struct ext4_xattr_ibody_find), GFP_NOFS);
 	bs = kzalloc(sizeof(struct ext4_xattr_block_find), GFP_NOFS);
-	buffer = kmalloc(value_size, GFP_NOFS);
+	buffer = kvmalloc(value_size, GFP_NOFS);
 	b_entry_name = kmalloc(entry->e_name_len + 1, GFP_NOFS);
 	if (!is || !bs || !buffer || !b_entry_name) {
 		error = -ENOMEM;
@@ -2608,7 +2608,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,
 	error = 0;
 out:
 	kfree(b_entry_name);
-	kfree(buffer);
+	kvfree(buffer);
 	if (is)
 		brelse(is->iloc.bh);
 	if (bs)
-- 
2.31.1


  parent reply	other threads:[~2022-12-08  2:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08  2:32 [PATCH v3 0/4] Fix two issue about ext4 extended attribute Ye Bin
2022-12-08  2:32 ` [PATCH v3 1/4] ext4: fix WARNING in ext4_expand_extra_isize_ea Ye Bin
2022-12-09  5:35   ` Theodore Ts'o
2022-12-08  2:32 ` Ye Bin [this message]
2022-12-09  5:35   ` [PATCH v3 2/4] ext4: allocate extended attribute value in vmalloc area Theodore Ts'o
2022-12-08  2:32 ` [PATCH v3 3/4] ext4: rename xattr_find_entry() and __xattr_check_inode() Ye Bin
2022-12-09  5:38   ` Theodore Ts'o
2022-12-08  2:32 ` [PATCH v3 4/4] ext4: fix inode leak in 'ext4_xattr_inode_create()' Ye Bin
2022-12-09  5:39   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221208023233.1231330-3-yebin@huaweicloud.com \
    --to=yebin@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®