mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <Mario.Limonciello@amd.com>,
	<ray.huang@amd.com>, <viresh.kumar@linaro.org>
Cc: <Deepak.Sharma@amd.com>, <Nathan.Fontenot@amd.com>,
	<Alexander.Deucher@amd.com>, <Shimmer.Huang@amd.com>,
	<Xiaojian.Du@amd.com>, <Li.Meng@amd.com>, <wyes.karny@amd.com>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v7 08/13] cpufreq: amd-pstate: add frequency dynamic boost sysfs control
Date: Thu, 8 Dec 2022 19:18:47 +0800	[thread overview]
Message-ID: <20221208111852.386731-9-perry.yuan@amd.com> (raw)
In-Reply-To: <20221208111852.386731-1-perry.yuan@amd.com>

From: Perry Yuan <Perry.Yuan@amd.com>

Add one sysfs entry to control the CPU cores frequency boost state
The attribute file can allow user to set max performance boosted or
keeping at normal perf level.

Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
 drivers/cpufreq/amd-pstate.c | 67 ++++++++++++++++++++++++++++++++++--
 1 file changed, 65 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index ea9255bdc9ac..4cd53c010215 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -69,6 +69,7 @@ static struct amd_pstate_params global_params;
 
 static DEFINE_MUTEX(amd_pstate_limits_lock);
 static DEFINE_MUTEX(amd_pstate_driver_lock);
+struct kobject *amd_pstate_kobj;
 
 static bool cppc_boost __read_mostly;
 
@@ -768,12 +769,46 @@ static ssize_t show_energy_performance_preference(
 	return sysfs_emit(buf, "%s\n", energy_perf_strings[preference]);
 }
 
+static void amd_pstate_update_policies(void)
+{
+	int cpu;
+
+	for_each_possible_cpu(cpu)
+		cpufreq_update_policy(cpu);
+}
+
+static ssize_t show_cppc_dynamic_boost(struct kobject *kobj,
+				struct kobj_attribute *attr, char *buf)
+{
+	return sysfs_emit(buf, "%u\n", cppc_boost);
+}
+
+static ssize_t store_cppc_dynamic_boost(struct kobject *a,
+				       struct kobj_attribute *b,
+				       const char *buf, size_t count)
+{
+	bool new_state;
+	int ret;
+
+	ret = kstrtobool(buf, &new_state);
+	if (ret)
+		return -EINVAL;
+
+	mutex_lock(&amd_pstate_driver_lock);
+	cppc_boost = !!new_state;
+	amd_pstate_update_policies();
+	mutex_unlock(&amd_pstate_driver_lock);
+
+	return count;
+}
+
 cpufreq_freq_attr_ro(amd_pstate_max_freq);
 cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
 
 cpufreq_freq_attr_ro(amd_pstate_highest_perf);
 cpufreq_freq_attr_rw(energy_performance_preference);
 cpufreq_freq_attr_ro(energy_performance_available_preferences);
+define_one_global_rw(cppc_dynamic_boost);
 
 static struct freq_attr *amd_pstate_attr[] = {
 	&amd_pstate_max_freq,
@@ -791,6 +826,15 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
 	NULL,
 };
 
+static struct attribute *pstate_global_attributes[] = {
+	&cppc_dynamic_boost.attr,
+	NULL
+};
+
+static const struct attribute_group amd_pstate_global_attr_group = {
+	.attrs = pstate_global_attributes,
+};
+
 static inline void update_boost_state(void)
 {
 	u64 misc_en;
@@ -1404,9 +1448,28 @@ static int __init amd_pstate_init(void)
 
 	ret = cpufreq_register_driver(default_pstate_driver);
 	if (ret)
-		pr_err("failed to register amd pstate driver with return %d\n",
-		       ret);
+		pr_err("failed to register driver with return %d\n", ret);
+
+	amd_pstate_kobj = kobject_create_and_add("amd-pstate", &cpu_subsys.dev_root->kobj);
+	if (!amd_pstate_kobj) {
+		ret = -EINVAL;
+		pr_err("global sysfs registration failed.\n");
+		goto kobject_free;
+	}
+
+	ret = sysfs_create_group(amd_pstate_kobj, &amd_pstate_global_attr_group);
+	if (ret) {
+		pr_err("sysfs attribute export failed with error %d.\n", ret);
+		goto global_attr_free;
+	}
+
+	return ret;
 
+global_attr_free:
+	kobject_put(amd_pstate_kobj);
+kobject_free:
+	cpufreq_unregister_driver(default_pstate_driver);
+	kfree(cpudata);
 	return ret;
 }
 device_initcall(amd_pstate_init);
-- 
2.34.1


  parent reply	other threads:[~2022-12-08 11:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 11:18 [PATCH v7 00/13] Implement AMD Pstate EPP Driver Perry Yuan
2022-12-08 11:18 ` [PATCH v7 01/13] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-12-09  7:55   ` Huang Rui
2022-12-12  3:29     ` Huang Rui
2022-12-12  9:17       ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 02/13] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-12-08 11:18 ` [PATCH v7 03/13] cpufreq: intel_pstate: use common macro definition for Energy Preference Performance(EPP) Perry Yuan
2022-12-09  8:01   ` Huang Rui
2022-12-09  8:54     ` Yuan, Perry
2022-12-12  1:28       ` Huang Rui
2022-12-19  8:51         ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 04/13] cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering Perry Yuan
2022-12-09  8:56   ` Huang Rui
2022-12-08 11:18 ` [PATCH v7 05/13] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2022-12-12  8:46   ` Huang Rui
2022-12-19 10:21     ` Yuan, Perry
2022-12-23  7:15       ` Huang Rui
2022-12-25 16:50         ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 06/13] cpufreq: amd-pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-12-12  9:02   ` Huang Rui
2022-12-19 10:27     ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 07/13] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-12-12  9:04   ` Huang Rui
2022-12-12 15:14     ` Limonciello, Mario
2022-12-19 10:33       ` Yuan, Perry
2022-12-08 11:18 ` Perry Yuan [this message]
2022-12-12 10:14   ` [PATCH v7 08/13] cpufreq: amd-pstate: add frequency dynamic boost sysfs control Huang Rui
2022-12-18 12:17   ` Thomas Koch
2022-12-19  6:56     ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 09/13] cpufreq: amd-pstate: add driver working mode status sysfs entry Perry Yuan
2022-12-12 10:24   ` Huang Rui
2022-12-19 10:29     ` Yuan, Perry
2022-12-08 11:18 ` [PATCH v7 10/13] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-12-08 11:18 ` [PATCH v7 11/13] Documentation: introduce amd pstate active mode kernel command line options Perry Yuan
2022-12-08 11:18 ` [PATCH v7 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit() Perry Yuan
2022-12-08 11:18 ` [PATCH v7 13/13] Documentation: amd-pstate: introduce new global sysfs attributes Perry Yuan
2022-12-08 11:36 ` [PATCH v7 00/13] Implement AMD Pstate EPP Driver Rafael J. Wysocki
2022-12-12  2:59   ` Yuan, Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221208111852.386731-9-perry.yuan@amd.com \
    --to=perry.yuan@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Deepak.Sharma@amd.com \
    --cc=Li.Meng@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Nathan.Fontenot@amd.com \
    --cc=Shimmer.Huang@amd.com \
    --cc=Xiaojian.Du@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ray.huang@amd.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wyes.karny@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®