From: Maxime Ripard <maxime@cerno.tech>
To: "Maíra Canal" <mcanal@igalia.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Melissa Wen" <mwen@igalia.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Emma Anholt" <emma@anholt.net>,
"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Wambui Karuga" <wambui@karuga.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] drm/vc4: use new debugfs device-centered functions
Date: Thu, 8 Dec 2022 13:11:31 +0100 [thread overview]
Message-ID: <20221208121131.cm2f6e33el5agf5p@houat> (raw)
In-Reply-To: <20221207132325.140393-4-mcanal@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Wed, Dec 07, 2022 at 10:23:22AM -0300, Maíra Canal wrote:
> Currently, vc4 has its own debugfs infrastructure that adds the debugfs
> files on drm_dev_register(). With the introduction of the new debugfs,
> functions, replace the vc4 debugfs structure with the DRM debugfs
> device-centered function, drm_debugfs_add_file().
>
> Moreover, remove the explicit error handling of debugfs related functions,
> considering that the only failure mode is -ENOMEM and also that error
> handling is not recommended for debugfs functions, as pointed out in [1].
>
> [1] https://lore.kernel.org/all/YWAmZdRwnAt6wh9B@kroah.com/
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-12-08 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:23 [PATCH v3 0/6] Introduce " Maíra Canal
2022-12-07 13:23 ` [PATCH v3 1/6] drm/debugfs: create device-centered debugfs functions Maíra Canal
2022-12-08 12:12 ` Maxime Ripard
2022-12-07 13:23 ` [PATCH v3 2/6] drm: use new debugfs device-centered functions on DRM core files Maíra Canal
2022-12-08 12:12 ` Maxime Ripard
2022-12-07 13:23 ` [PATCH v3 3/6] drm/vc4: use new debugfs device-centered functions Maíra Canal
2022-12-08 12:11 ` Maxime Ripard [this message]
2022-12-07 13:23 ` [PATCH v3 4/6] drm/v3d: " Maíra Canal
2022-12-07 13:23 ` [PATCH v3 5/6] drm/vkms: " Maíra Canal
2022-12-07 13:23 ` [PATCH v3 6/6] drm/todo: update the debugfs clean up task Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208121131.cm2f6e33el5agf5p@houat \
--to=maxime@cerno.tech \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mwen@igalia.com \
--cc=ogabbay@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=tzimmermann@suse.de \
--cc=wambui@karuga.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®