From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16FBC4332F for ; Thu, 8 Dec 2022 19:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbiLHTQL (ORCPT ); Thu, 8 Dec 2022 14:16:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiLHTQH (ORCPT ); Thu, 8 Dec 2022 14:16:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9CFD3B9FA for ; Thu, 8 Dec 2022 11:16:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8519262041 for ; Thu, 8 Dec 2022 19:16:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99279C433D2; Thu, 8 Dec 2022 19:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670526965; bh=z+N9fxN1bumG6ozwZdWvrjtq+nRyqeqSupSvs69OVrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BwypU2hNY7NgOh1p7KJEQ4LM+yeyqspNCdMEiltGeI7JutjiOPmKB1Lb6F2Z4Eyy0 GO0bH9pcyBTLMLaZgiOtXyRyvdMg9SYJMaljRKLTpTcNYQwDD5TWeBr2p4wmxvsHzh mSwcJAA+cYWHjnKhz6/5kCFsC0eoFgiKLiwwX4KkKmitn0LBNj2M8k4Yr18bK6VSef VluN3NaRARFgB+WaS2/88qwW2YH7eam281dGEqs6XE+4/jHBmap9Ngrw9xq7Mbr0XN saM9/8XN7YCiXSo2SdHxfhfacxtw6fimmqBqwfnngcr26DdrpYAY6ykM5RNj/XGmZZ DNqVLy0+8yvEQ== Received: by pali.im (Postfix) id CF87B97E; Thu, 8 Dec 2022 20:16:02 +0100 (CET) Date: Thu, 8 Dec 2022 20:16:02 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Cc: Michael Ellerman , Joel Stanley , Benjamin Herrenschmidt , Paul Mackerras , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage Message-ID: <20221208191602.diywrt3g2f6zmt4s@pali> References: <20220820105200.30425-1-pali@kernel.org> <20220828095659.4061-1-pali@kernel.org> <20220828174135.rcql4uiunqbnn5gh@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote: > Le 28/08/2022 à 19:41, Pali Rohár a écrit : > > On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote: > >> Le 28/08/2022 à 19:33, Christophe Leroy a écrit : > >>> > >>> > >>> Le 28/08/2022 à 11:56, Pali Rohár a écrit : > >>>> When CONFIG_TARGET_CPU is specified then pass its value to the compiler > >>>> -mcpu option. This fixes following build error when building kernel with > >>>> powerpc e500 SPE capable cross compilers: > >>>> > >>>>      BOOTAS  arch/powerpc/boot/crt0.o > >>>>    powerpc-linux-gnuspe-gcc: error: unrecognized argument in option > >>>> ‘-mcpu=powerpc’ > >>>>    powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: > >>>> 8540 8548 native > >>>>    make[1]: *** [arch/powerpc/boot/Makefile:231: > >>>> arch/powerpc/boot/crt0.o] Error 1 > >>> > >>> corenet64_smp_defconfig : > >>> > >>>   BOOTAS  arch/powerpc/boot/crt0.o > >>> powerpc64-linux-gcc: error: missing argument to '-mcpu=' > >>> make[1]: *** [arch/powerpc/boot/Makefile:237 : arch/powerpc/boot/crt0.o] > >>> Erreur 1 > >>> make: *** [arch/powerpc/Makefile:253 : uImage] Erreur 2 > >>> > >>> > >> > >> Seems like in fact, E5500_CPU and E6500_CPU are not taken into account > >> in CONFIG_TARGET_CPU, and get special treatment directly in > >> arch/powerpc/Makefile. > >> > >> This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += > >> $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU)) > >> > >> I think we need to fix that prior to your patch. > > > > It looks like that CONFIG_TARGET_CPU is broken. > > > > $ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- > > ... > > # configuration written to .config > > > > $ grep CONFIG_TARGET_CPU .config > > CONFIG_TARGET_CPU_BOOL=y > > > > CONFIG_TARGET_CPU_BOOL is set but CONFIG_TARGET_CPU not! > > Yes, because there is no default value for E5500_CPU and E6500_CPU. We > need to add one for each. With "[PATCH v1] powerpc/64: Set default CPU in Kconfig" patch from https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/ this change does not throw above compile error anymore. > > > >>> Christophe > >>> > >>> > >>>> > >>>> Similar change was already introduced for the main powerpc Makefile in > >>>> commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the > >>>> compiler"). > >>>> > >>>> Fixes: 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate > >>>> CPU") > >>>> Cc: stable@vger.kernel.org # 446cda1b21d9 ("powerpc/32: Don't always > >>>> pass -mcpu=powerpc to the compiler") > >>>> Signed-off-by: Pali Rohár > >>>> --- > >>>>   arch/powerpc/boot/Makefile | 14 ++++++++++---- > >>>>   1 file changed, 10 insertions(+), 4 deletions(-) > >>>> > >>>> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > >>>> index a9cd2ea4a861..1957a3de7a1c 100644 > >>>> --- a/arch/powerpc/boot/Makefile > >>>> +++ b/arch/powerpc/boot/Makefile > >>>> @@ -38,13 +38,19 @@ BOOTCFLAGS    := -Wall -Wundef -Wstrict-prototypes > >>>> -Wno-trigraphs \ > >>>>            $(LINUXINCLUDE) > >>>>   ifdef CONFIG_PPC64_BOOT_WRAPPER > >>>> -ifdef CONFIG_CPU_LITTLE_ENDIAN > >>>> -BOOTCFLAGS    += -m64 -mcpu=powerpc64le > >>>> +BOOTCFLAGS    += -m64 > >>>>   else > >>>> -BOOTCFLAGS    += -m64 -mcpu=powerpc64 > >>>> +BOOTCFLAGS    += -m32 > >>>>   endif > >>>> + > >>>> +ifdef CONFIG_TARGET_CPU_BOOL > >>>> +BOOTCFLAGS    += -mcpu=$(CONFIG_TARGET_CPU) > >>>> +else ifdef CONFIG_PPC64_BOOT_WRAPPER > >>>> +ifdef CONFIG_CPU_LITTLE_ENDIAN > >>>> +BOOTCFLAGS    += -mcpu=powerpc64le > >>>>   else > >>>> -BOOTCFLAGS    += -m32 -mcpu=powerpc > >>>> +BOOTCFLAGS    += -mcpu=powerpc64 > >>>> +endif > >>>>   endif > >>>>   BOOTCFLAGS    += -isystem $(shell $(BOOTCC) -print-file-name=include)