From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Josh Triplett <josh@joshtriplett.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, connoro@google.com
Subject: [PATCH v2 2/2] locktorture: Make the rt_boost factor a tunable
Date: Fri, 9 Dec 2022 02:23:05 +0000 [thread overview]
Message-ID: <20221209022305.321149-2-joel@joelfernandes.org> (raw)
In-Reply-To: <20221209022305.321149-1-joel@joelfernandes.org>
The rt boosting in locktorture has a factor variable s currently large enough
that boosting only happens once every minute or so. Add a tunable to reduce the
factor so that boosting happens more often, to test paths and arrive at failure
modes earlier. With this change, I can set the factor to like 50 and have the
boosting happens every 10 seconds or so.
Tested with boot parameters:
locktorture.torture_type=mutex_lock
locktorture.onoff_interval=1
locktorture.nwriters_stress=8
locktorture.stutter=0
locktorture.rt_boost=1
locktorture.rt_boost_factor=50
locktorture.nlocks=3
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
kernel/locking/locktorture.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index 8968fd65a90d..b64a528e511c 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -48,6 +48,7 @@ torture_param(int, stat_interval, 60,
torture_param(int, stutter, 5, "Number of jiffies to run/halt test, 0=disable");
torture_param(int, rt_boost, 2,
"Do periodic rt-boost. 0=Disable, 1=Only for rt_mutex, 2=For all lock types.");
+torture_param(int, rt_boost_factor, 50, "A factor determining how often rt-boost happens.");
torture_param(int, verbose, 1,
"Enable verbose debugging printk()s");
torture_param(int, nlocks, 1,
@@ -133,12 +134,12 @@ static void torture_lock_busted_write_unlock(int tid __maybe_unused)
static void __torture_rt_boost(struct torture_random_state *trsp)
{
- const unsigned int factor = 50000; /* yes, quite arbitrary */
+ const unsigned int factor = rt_boost_factor;
if (!rt_task(current)) {
/*
- * Boost priority once every ~50k operations. When the
- * task tries to take the lock, the rtmutex it will account
+ * Boost priority once every rt_boost_factor operations. When
+ * the task tries to take the lock, the rtmutex it will account
* for the new priority, and do any corresponding pi-dance.
*/
if (trsp && !(torture_random(trsp) %
@@ -148,8 +149,9 @@ static void __torture_rt_boost(struct torture_random_state *trsp)
return;
} else {
/*
- * The task will remain boosted for another ~500k operations,
- * then restored back to its original prio, and so forth.
+ * The task will remain boosted for another 10*rt_boost_factor
+ * operations, then restored back to its original prio, and so
+ * forth.
*
* When @trsp is nil, we want to force-reset the task for
* stopping the kthread.
--
2.39.0.rc1.256.g54fd8350bd-goog
next prev parent reply other threads:[~2022-12-09 2:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 2:23 [PATCH v2 1/2] locktorture: Allow non-rtmutex lock types to be boosted Joel Fernandes (Google)
2022-12-09 2:23 ` Joel Fernandes (Google) [this message]
2022-12-09 16:37 ` [PATCH v2 2/2] locktorture: Make the rt_boost factor a tunable Davidlohr Bueso
2022-12-09 21:51 ` Joel Fernandes
2022-12-09 22:32 ` Davidlohr Bueso
2022-12-09 23:23 ` Joel Fernandes
2022-12-09 2:26 ` [PATCH v2 1/2] locktorture: Allow non-rtmutex lock types to be boosted Joel Fernandes
2022-12-09 3:25 ` Davidlohr Bueso
2022-12-09 3:58 ` Joel Fernandes
2022-12-09 16:34 ` Davidlohr Bueso
2022-12-09 17:02 ` Joel Fernandes
2022-12-13 20:24 ` Paul E. McKenney
2022-12-13 20:51 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209022305.321149-2-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=connoro@google.com \
--cc=dave@stgolabs.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®