From: Sven Schnelle <svens@linux.ibm.com>
To: Willy Tarreau <w@1wt.eu>,
"Paul E . McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] nolibc: fix fd_set type
Date: Fri, 9 Dec 2022 15:19:35 +0100 [thread overview]
Message-ID: <20221209141939.3634586-2-svens@linux.ibm.com> (raw)
In-Reply-To: <20221209141939.3634586-1-svens@linux.ibm.com>
The kernel uses unsigned long for the fd_set bitmap,
but nolibc use u32. This works fine on little endian
machines, but fails on big endian. Convert to unsigned
long to fix this.
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
tools/include/nolibc/types.h | 53 ++++++++++++++++++++----------------
1 file changed, 30 insertions(+), 23 deletions(-)
diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
index 959997034e55..300e0ff1cd58 100644
--- a/tools/include/nolibc/types.h
+++ b/tools/include/nolibc/types.h
@@ -89,39 +89,46 @@
#define EXIT_SUCCESS 0
#define EXIT_FAILURE 1
+#define FD_SETIDXMASK (8 * sizeof(unsigned long))
+#define FD_SETBITMASK (8 * sizeof(unsigned long)-1)
+
/* for select() */
typedef struct {
- uint32_t fd32[(FD_SETSIZE + 31) / 32];
+ unsigned long fds[(FD_SETSIZE + FD_SETBITMASK) / FD_SETIDXMASK];
} fd_set;
-#define FD_CLR(fd, set) do { \
- fd_set *__set = (set); \
- int __fd = (fd); \
- if (__fd >= 0) \
- __set->fd32[__fd / 32] &= ~(1U << (__fd & 31)); \
+#define FD_CLR(fd, set) do { \
+ fd_set *__set = (set); \
+ int __fd = (fd); \
+ if (__fd >= 0) \
+ __set->fds[__fd / FD_SETIDXMASK] &= \
+ ~(1U << (__fd & FX_SETBITMASK)); \
} while (0)
-#define FD_SET(fd, set) do { \
- fd_set *__set = (set); \
- int __fd = (fd); \
- if (__fd >= 0) \
- __set->fd32[__fd / 32] |= 1U << (__fd & 31); \
+#define FD_SET(fd, set) do { \
+ fd_set *__set = (set); \
+ int __fd = (fd); \
+ if (__fd >= 0) \
+ __set->fds[__fd / FD_SETIDXMASK] |= \
+ 1 << (__fd & FD_SETBITMASK); \
} while (0)
-#define FD_ISSET(fd, set) ({ \
- fd_set *__set = (set); \
- int __fd = (fd); \
- int __r = 0; \
- if (__fd >= 0) \
- __r = !!(__set->fd32[__fd / 32] & 1U << (__fd & 31)); \
- __r; \
+#define FD_ISSET(fd, set) ({ \
+ fd_set *__set = (set); \
+ int __fd = (fd); \
+ int __r = 0; \
+ if (__fd >= 0) \
+ __r = !!(__set->fds[__fd / FD_SETIDXMASK] & \
+1U << (__fd & FD_SET_BITMASK)); \
+ __r; \
})
-#define FD_ZERO(set) do { \
- fd_set *__set = (set); \
- int __idx; \
- for (__idx = 0; __idx < (FD_SETSIZE+31) / 32; __idx ++) \
- __set->fd32[__idx] = 0; \
+#define FD_ZERO(set) do { \
+ fd_set *__set = (set); \
+ int __idx; \
+ int __size = (FD_SETSIZE+FD_SETBITMASK) / FD_SETIDXMASK;\
+ for (__idx = 0; __idx < __size; __idx++) \
+ __set->fds[__idx] = 0; \
} while (0)
/* for poll() */
--
2.34.1
next prev parent reply other threads:[~2022-12-09 14:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 14:19 [PATCH 0/5] add s390 support to nolibc and rcutorture Sven Schnelle
2022-12-09 14:19 ` Sven Schnelle [this message]
2022-12-10 8:46 ` [PATCH 1/5] nolibc: fix fd_set type Willy Tarreau
2022-12-09 14:19 ` [PATCH 2/5] nolibc: add support for s390 Sven Schnelle
2022-12-10 9:07 ` Willy Tarreau
2022-12-10 9:34 ` Sven Schnelle
2022-12-10 9:37 ` Willy Tarreau
2022-12-10 9:39 ` Sven Schnelle
2022-12-10 9:44 ` Willy Tarreau
2022-12-10 17:57 ` Paul E. McKenney
2022-12-10 22:05 ` Willy Tarreau
2022-12-11 5:51 ` Paul E. McKenney
2022-12-27 21:35 ` Willy Tarreau
2023-01-02 8:17 ` Sven Schnelle
2023-01-02 8:41 ` Willy Tarreau
2023-01-02 9:33 ` Sven Schnelle
2023-01-02 9:50 ` Willy Tarreau
2022-12-09 14:19 ` [PATCH 3/5] selftests/nolibc: add s390 support Sven Schnelle
2022-12-10 9:08 ` Willy Tarreau
2022-12-09 14:19 ` [PATCH 4/5] rcutorture: add support for s390 Sven Schnelle
2022-12-09 14:19 ` [PATCH 5/5] rcutorture: build initrd for rcutorture with nolibc Sven Schnelle
2022-12-09 15:03 ` [PATCH 0/5] add s390 support to nolibc and rcutorture Paul E. McKenney
2022-12-09 15:28 ` Willy Tarreau
2022-12-10 1:26 ` Paul E. McKenney
2022-12-10 9:12 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209141939.3634586-2-svens@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®