From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <nicolas.ferre@microchip.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>, <andrew@lunn.ch>, <hkallweit1@gmail.com>
Cc: <sergiu.moga@microchip.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH v2 1/2] net: phylink: init phydev on phylink_resume()
Date: Mon, 12 Dec 2022 13:28:44 +0200 [thread overview]
Message-ID: <20221212112845.73290-2-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <20221212112845.73290-1-claudiu.beznea@microchip.com>
There are scenarios where PHY power is cut off on system suspend.
There are also MAC drivers which handles themselves the PHY on
suspend/resume path. For such drivers the
struct phy_device::mac_managed_phy is set to true and thus the
mdio_bus_phy_suspend()/mdio_bus_phy_resume() wouldn't do the
proper PHY suspend/resume. For such scenarios call phy_init_hw()
from phylink_resume().
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
Hi, Russel,
I let phy_init_hw() to execute for all devices. I can restrict it only
for PHYs that has struct phy_device::mac_managed_phy = true.
Please let me know what you think.
Thank you,
Claudiu Beznea
drivers/net/phy/phylink.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 09cc65c0da93..6003c329638e 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -2031,6 +2031,12 @@ void phylink_resume(struct phylink *pl)
{
ASSERT_RTNL();
+ if (pl->phydev) {
+ int ret = phy_init_hw(pl->phydev);
+ if (ret)
+ return;
+ }
+
if (test_bit(PHYLINK_DISABLE_MAC_WOL, &pl->phylink_disable_state)) {
/* Wake-on-Lan enabled, MAC handling */
--
2.34.1
next prev parent reply other threads:[~2022-12-12 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 11:28 [PATCH v2 0/2] net: macb: fix connectivity after resume Claudiu Beznea
2022-12-12 11:28 ` Claudiu Beznea [this message]
2022-12-12 12:47 ` [PATCH v2 1/2] net: phylink: init phydev on phylink_resume() Russell King (Oracle)
2022-12-12 13:26 ` Claudiu.Beznea
2022-12-12 14:24 ` Russell King (Oracle)
2022-12-12 14:46 ` Claudiu.Beznea
2022-12-12 13:54 ` Vladimir Oltean
2022-12-12 15:20 ` Claudiu.Beznea
2022-12-12 11:28 ` [PATCH v2 2/2] net: macb: use phylink_suspend()/phylink_resume() Claudiu Beznea
2022-12-14 1:39 ` [PATCH v2 0/2] net: macb: fix connectivity after resume Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212112845.73290-2-claudiu.beznea@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=sergiu.moga@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®