From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>, SeongJae Park <sj@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<damon@lists.linux.dev>, <vishal.moola@gmail.com>,
<willy@infradead.org>, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH -next 6/8] mm: damon: paddr: convert damon_pa_*() to use folios
Date: Tue, 13 Dec 2022 17:27:33 +0800 [thread overview]
Message-ID: <20221213092735.187924-7-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20221213092735.187924-1-wangkefeng.wang@huawei.com>
With damon_get_folio(), let's convert damon_ptep_mkold() and
damon_pmdp_mkold() to use folios.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/damon/paddr.c | 44 +++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index 6b36de1396a4..95d4686611a5 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -33,17 +33,15 @@ static bool __damon_pa_mkold(struct folio *folio, struct vm_area_struct *vma,
static void damon_pa_mkold(unsigned long paddr)
{
- struct folio *folio;
- struct page *page = damon_get_page(PHYS_PFN(paddr));
+ struct folio *folio = damon_get_folio(PHYS_PFN(paddr));
struct rmap_walk_control rwc = {
.rmap_one = __damon_pa_mkold,
.anon_lock = folio_lock_anon_vma_read,
};
bool need_lock;
- if (!page)
+ if (!folio)
return;
- folio = page_folio(page);
if (!folio_mapped(folio) || !folio_raw_mapping(folio)) {
folio_set_idle(folio);
@@ -93,7 +91,7 @@ static bool __damon_pa_young(struct folio *folio, struct vm_area_struct *vma,
DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, addr, 0);
result->accessed = false;
- result->page_sz = PAGE_SIZE;
+ result->page_sz = PAGE_SIZE * folio_nr_pages(folio);
while (page_vma_mapped_walk(&pvmw)) {
addr = pvmw.address;
if (pvmw.pte) {
@@ -122,8 +120,7 @@ static bool __damon_pa_young(struct folio *folio, struct vm_area_struct *vma,
static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz)
{
- struct folio *folio;
- struct page *page = damon_get_page(PHYS_PFN(paddr));
+ struct folio *folio = damon_get_folio(PHYS_PFN(paddr));
struct damon_pa_access_chk_result result = {
.page_sz = PAGE_SIZE,
.accessed = false,
@@ -135,9 +132,8 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz)
};
bool need_lock;
- if (!page)
+ if (!folio)
return false;
- folio = page_folio(page);
if (!folio_mapped(folio) || !folio_raw_mapping(folio)) {
if (folio_test_idle(folio))
@@ -205,28 +201,28 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx)
static unsigned long damon_pa_pageout(struct damon_region *r)
{
unsigned long addr, applied;
- LIST_HEAD(page_list);
+ LIST_HEAD(folio_list);
for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) {
- struct page *page = damon_get_page(PHYS_PFN(addr));
+ struct folio *folio = damon_get_folio(PHYS_PFN(addr));
- if (!page)
+ if (!folio)
continue;
- ClearPageReferenced(page);
- test_and_clear_page_young(page);
- if (isolate_lru_page(page)) {
- put_page(page);
+ folio_clear_referenced(folio);
+ folio_test_clear_young(folio);
+ if (folio_isolate_lru(folio)) {
+ folio_put(folio);
continue;
}
- if (PageUnevictable(page)) {
- putback_lru_page(page);
+ if (folio_test_unevictable(folio)) {
+ folio_putback_lru(folio);
} else {
- list_add(&page->lru, &page_list);
- put_page(page);
+ list_add(&folio->lru, &folio_list);
+ folio_put(folio);
}
}
- applied = reclaim_pages(&page_list);
+ applied = reclaim_pages(&folio_list);
cond_resched();
return applied * PAGE_SIZE;
}
@@ -237,12 +233,10 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate(
unsigned long addr, applied = 0;
for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) {
- struct page *page = damon_get_page(PHYS_PFN(addr));
- struct folio *folio;
+ struct folio *folio = damon_get_folio(PHYS_PFN(addr));
- if (!page)
+ if (!folio)
continue;
- folio = page_folio(page);
if (mark_accessed)
folio_mark_accessed(folio);
--
2.35.3
next prev parent reply other threads:[~2022-12-13 9:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:27 [PATCH -next 0/8] mm: converted page idle and damon " Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 1/8] mm: memory_hotplug: add pfn_to_online_folio() Kefeng Wang
2022-12-13 11:13 ` kernel test robot
2022-12-13 11:36 ` Kefeng Wang
2022-12-13 11:23 ` kernel test robot
2022-12-13 11:40 ` David Hildenbrand
2022-12-13 12:13 ` Kefeng Wang
2022-12-13 14:42 ` David Hildenbrand
2022-12-13 14:47 ` Matthew Wilcox
2022-12-14 1:10 ` Kefeng Wang
2022-12-13 12:03 ` kernel test robot
2022-12-14 4:15 ` kernel test robot
2022-12-13 9:27 ` [PATCH -next 2/8] mm: page_idle: Convert page idle to use folios Kefeng Wang
2022-12-13 14:34 ` Matthew Wilcox
2022-12-13 19:14 ` SeongJae Park
2022-12-13 9:27 ` [PATCH -next 3/8] mm: huge_memory: convert split_huge_pages_all() " Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 4/8] mm: damon: add temporary damon_get_folio() Kefeng Wang
2022-12-13 14:40 ` Matthew Wilcox
2022-12-13 19:18 ` SeongJae Park
2022-12-13 9:27 ` [PATCH -next 5/8] mm: damon: convert damon_ptep/pmdp_mkold() to use folios Kefeng Wang
2022-12-13 9:27 ` Kefeng Wang [this message]
2022-12-13 9:27 ` [PATCH -next 7/8] mm: damon: vaddr: convert damon_young_pmd_entry() to use folio Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 8/8] mm: damon: remove unneed damon_get_page() Kefeng Wang
2022-12-13 19:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213092735.187924-7-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=sj@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®