From: Yangtao Li <frank.li@vivo.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: do some cleanup for f2fs module init
Date: Tue, 13 Dec 2022 20:09:46 +0800 [thread overview]
Message-ID: <20221213120946.16875-1-frank.li@vivo.com> (raw)
In-Reply-To: <635cee2a-3f11-b963-b800-b417be7007b5@kernel.org>
>>>>> I don't think this needs cleanup, other part looks good to me.
>>>>
>>>> What is the point here comparing to the below? fyi; I picked this change.
>>>
>>> IIUC, the question is for Yangtao? :P
>>
>> Heh, to you. :) I think either looks fine. Hence,
>
> Ah... alright.
> I comment on this cleanup, due to I don't see any benefit, since both implementations are very common in kernel codes.
Mainly the cleanup of f2fs_init_compress_cache() and f2fs_init_bioset functions().
For other parts, I don't think it is necessary to take up too many lines, just deal with them by the way. :D
Thx,
Yangtao
prev parent reply other threads:[~2022-12-13 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 11:47 Yangtao Li
2022-12-11 2:14 ` Chao Yu
2022-12-12 22:53 ` Jaegeuk Kim
2022-12-13 1:34 ` Chao Yu
2022-12-13 1:37 ` Jaegeuk Kim
2022-12-13 2:02 ` Chao Yu
2022-12-13 12:09 ` Yangtao Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213120946.16875-1-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®