From: Wenchao Hao <haowenchao@huawei.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
Mike Christie <michael.christie@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
<open-iscsi@googlegroups.com>, <linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <liuzhiqiang26@huawei.com>,
<linfeilong@huawei.com>, Wenchao Hao <haowenchao@huawei.com>
Subject: [PATCH 0/2] scsi:donot skip lun if inquiry returns PQ=1 for all hosts
Date: Wed, 14 Dec 2022 15:08:44 +0800 [thread overview]
Message-ID: <20221214070846.1808300-1-haowenchao@huawei.com> (raw)
commit 948e922fc4461 ("scsi: core: map PQ=1, PDT=other values to
SCSI_SCAN_TARGET_PRESENT") returns SCSI_SCAN_TARGET_PRESENT if inquiry
returns PQ=1.
According to the SPC, PQ=1 means the addressed logical unit having the
indicated device type is not accessible, it does not mean the addressed
logical unit is invalid. We still can map this lun to an sg device.
In some conditions, we do not want to skip these devices, for example
with iSCSI:
When iSCSI initiator logged in target, the target attached none valid
lun but lun0. lun0 is not an valid disk, while it would response
inquiry command with PQ=1 and other general scsi commands like probe lun.
The others luns of target is added/removed dynamicly.
We want the lun0 to be mapped to an sg device in initiator, so we can
probe luns of target based on lun0.
In first patch, I add an interface to control if to skip luns return
PQ=1 for inquiry.
In second patch, make iscsi_tcp do not skip luns return PQ=1 as default,
since I do not have iscsi_tcp environment, so here just modified the
iscsi_tcp.
Wenchao Hao (2):
scsi:core:Add sysfs interface to control if skip lun with PQ=1
scsi:iscsi_tcp:Do not skip lun inquiry returns PQ=1
drivers/scsi/iscsi_tcp.c | 1 +
drivers/scsi/scsi_scan.c | 9 ++++++---
drivers/scsi/scsi_sysfs.c | 29 +++++++++++++++++++++++++++++
include/scsi/scsi_host.h | 3 +++
4 files changed, 39 insertions(+), 3 deletions(-)
--
2.32.0
next reply other threads:[~2022-12-14 7:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 7:08 Wenchao Hao [this message]
2022-12-14 7:08 ` [PATCH 1/2] scsi:core:Add sysfs interface to control if skip lun with PQ=1 Wenchao Hao
2022-12-18 21:37 ` Mike Christie
2022-12-28 8:46 ` Wenchao Hao
2022-12-14 7:08 ` [PATCH 2/2] scsi:iscsi_tcp:Do not skip lun inquiry returns PQ=1 Wenchao Hao
2022-12-15 7:06 ` [PATCH 0/2] scsi:donot skip lun if inquiry returns PQ=1 for all hosts Christoph Hellwig
2022-12-15 8:07 ` Antw: [EXT] " Ulrich Windl
2022-12-16 7:11 ` Christoph Hellwig
2022-12-15 9:09 ` Wenchao Hao
2022-12-16 7:12 ` Christoph Hellwig
2022-12-16 11:41 ` Wenchao Hao
2022-12-23 15:54 ` Christoph Hellwig
2022-12-28 9:35 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214070846.1808300-1-haowenchao@huawei.com \
--to=haowenchao@huawei.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®