From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F98C4332F for ; Wed, 14 Dec 2022 20:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbiLNUj5 (ORCPT ); Wed, 14 Dec 2022 15:39:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbiLNUjc (ORCPT ); Wed, 14 Dec 2022 15:39:32 -0500 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [5.144.164.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E54DF1 for ; Wed, 14 Dec 2022 12:37:40 -0800 (PST) Received: from SoMainline.org (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 03B163F256; Wed, 14 Dec 2022 21:37:38 +0100 (CET) Date: Wed, 14 Dec 2022 21:37:37 +0100 From: Marijn Suijten To: Krzysztof Kozlowski Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] arm64: dts: qcom: Use plural _gpios node label for PMIC gpios Message-ID: <20221214203737.icoc6zan5edkhtcz@SoMainline.org> Mail-Followup-To: Marijn Suijten , Krzysztof Kozlowski , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221209220450.1793421-1-marijn.suijten@somainline.org> <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org> <20221210170531.pxoux2kje4vgor5y@SoMainline.org> <5795a42d-7920-713a-0d90-df32d657d365@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5795a42d-7920-713a-0d90-df32d657d365@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-11 21:07:47, Krzysztof Kozlowski wrote: > On 10/12/2022 18:05, Marijn Suijten wrote: > > [..] > > Just like -state and -pins suffix, sometimes even the unnecessary > > -pins-pins suffix? To me that is the same kind of churn, and *it is > > You compare now to node names. The node names have visible impact (name > of devices in sysfs and in system), is affected by DT schema (is parsed) > and should follow DT spec rules. > > There is nothing like that about labels, therefore they do not have the > same rules or importance. > > I understand that consistency in labels might be good thing... but also > it does not matter. The labels really do not matter, except the code > readability. pmgpio or pmgpios is basically the same readable. For me the latter is more readable, and not only catering to userspace/sysfs but also to the developer reading/writing these DTs is a good thing (where it doesn't affect userspace nor sysfs, like this patch). - Marijn