mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
	"Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Serge Semin <fancer.lancer@gmail.com>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
	caihuoqing <caihuoqing@baidu.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	<linux-pci@vger.kernel.org>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v7 23/25] PCI: dwc: Restore DMA-mask after MSI-data allocation
Date: Thu, 15 Dec 2022 02:53:03 +0300	[thread overview]
Message-ID: <20221214235305.31744-24-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20221214235305.31744-1-Sergey.Semin@baikalelectronics.ru>

DW PCIe Root Ports and End-points can be equipped with the DW eDMA engine.
In that case it is critical to have the platform device pre-initialized
with a valid DMA-mask so the drivers using the eDMA-engine would be able
to allocate the DMA-able buffers. The MSI-capable data requires to be
allocated from the lowest 4GB region. Since that procedure implies the
DMA-mask change we need to restore the mask set by the low-level drivers
after the MSI-data allocation is done.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

---

Changelog v7:
- This is a new patch added on v7 stage of the series. (@Robin)
---
 drivers/pci/controller/dwc/pcie-designware-host.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 5762bd306261..1a3dae1f6aa2 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -326,7 +326,7 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
 	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
 	struct device *dev = pci->dev;
 	struct platform_device *pdev = to_platform_device(dev);
-	u64 *msi_vaddr;
+	u64 *msi_vaddr, dma_mask;
 	int ret;
 	u32 ctrl, num_ctrls;
 
@@ -366,6 +366,13 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
 						    dw_chained_msi_isr, pp);
 	}
 
+	/*
+	 * Save and then restore the DMA-mask pre-set by the low-level drivers
+	 * after allocating the MSI-capable region. The mask might be useful for
+	 * the controllers with the embedded eDMA engine.
+	 */
+	dma_mask = dma_get_mask(dev);
+
 	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
 	if (ret)
 		dev_warn(dev, "Failed to set DMA mask to 32-bit. Devices with only 32-bit MSI support may not work properly\n");
@@ -378,6 +385,10 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
 		return -ENOMEM;
 	}
 
+	ret = dma_set_mask_and_coherent(dev, dma_mask);
+	if (ret)
+		dev_warn(dev, "Failed to re-store DMA-mask\n");
+
 	return 0;
 }
 
-- 
2.38.1



  parent reply	other threads:[~2022-12-14 23:55 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 23:52 [PATCH v7 00/25] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-12-14 23:52 ` [PATCH v7 01/25] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-12-14 23:52 ` [PATCH v7 02/25] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-12-14 23:52 ` [PATCH v7 03/25] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-12-14 23:52 ` [PATCH v7 04/25] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-12-14 23:52 ` [PATCH v7 05/25] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-12-14 23:52 ` [PATCH v7 06/25] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-12-14 23:52 ` [PATCH v7 07/25] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-12-14 23:52 ` [PATCH v7 08/25] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-12-14 23:52 ` [PATCH v7 09/25] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-12-14 23:52 ` [PATCH v7 10/25] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-12-14 23:52 ` [PATCH v7 11/25] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-12-14 23:52 ` [PATCH v7 12/25] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-12-14 23:52 ` [PATCH v7 13/25] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-12-14 23:52 ` [PATCH v7 14/25] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-12-14 23:52 ` [PATCH v7 15/25] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-12-14 23:52 ` [PATCH v7 16/25] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-12-14 23:52 ` [PATCH v7 17/25] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-12-14 23:52 ` [PATCH v7 18/25] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-12-14 23:52 ` [PATCH v7 19/25] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-12-14 23:53 ` [PATCH v7 20/25] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-12-14 23:53 ` [PATCH v7 21/25] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-12-14 23:53 ` [PATCH v7 22/25] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-12-14 23:53 ` Serge Semin [this message]
2022-12-15  0:03   ` [PATCH v7 23/25] PCI: dwc: Restore DMA-mask after MSI-data allocation Serge Semin
2022-12-15  7:13   ` Christoph Hellwig
2022-12-15  9:27     ` Serge Semin
2022-12-15 10:26       ` Robin Murphy
2022-12-15 23:52         ` Serge Semin
2022-12-16  7:39           ` Christoph Hellwig
2022-12-16  9:34             ` Serge Semin
2022-12-16  9:49               ` Christoph Hellwig
2022-12-16 10:18                 ` Serge Semin
2022-12-16 14:01                   ` Robin Murphy
2022-12-16 17:02                     ` Serge Semin
2022-12-14 23:53 ` [PATCH v7 24/25] PCI: bt1: Set 64-bit DMA-mask Serge Semin
2023-01-13 12:04   ` Lorenzo Pieralisi
2023-01-13 12:12     ` Serge Semin
2023-01-13 17:40     ` Robin Murphy
2023-01-13 18:23       ` Serge Semin
2022-12-14 23:53 ` [PATCH v7 25/25] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-12-15 12:25   ` kernel test robot
2022-12-15 17:08   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214235305.31744-24-Sergey.Semin@baikalelectronics.ru \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Frank.Li@nxp.com \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=bhelgaas@google.com \
    --cc=cai.huoqing@linux.dev \
    --cc=caihuoqing@baidu.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®