From: ChenXiaoSong <chenxiaosong2@huawei.com>
To: <bvanassche@acm.org>, <slava@dubeyko.com>,
<akpm@linux-foundation.org>, <gargaditya08@live.com>,
<axboe@kernel.dk>, <chenxiaosong2@huawei.com>,
<willy@infradead.org>, <damien.lemoal@opensource.wdc.com>,
<jlayton@kernel.org>, <hannes@cmpxchg.org>, <tytso@mit.edu>,
<muchun.song@linux.dev>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/2] hfsplus: introduce hfsplus_init_inode() helper
Date: Thu, 15 Dec 2022 16:18:19 +0800 [thread overview]
Message-ID: <20221215081820.948990-2-chenxiaosong2@huawei.com> (raw)
In-Reply-To: <20221215081820.948990-1-chenxiaosong2@huawei.com>
Factor out hfsplus_init_inode(), No functional change.
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
fs/hfsplus/hfsplus_fs.h | 1 +
fs/hfsplus/inode.c | 35 ++++++++++++++++++++---------------
2 files changed, 21 insertions(+), 15 deletions(-)
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
index 6aa919e59483..2aa719e00ae5 100644
--- a/fs/hfsplus/hfsplus_fs.h
+++ b/fs/hfsplus/hfsplus_fs.h
@@ -472,6 +472,7 @@ extern const struct dentry_operations hfsplus_dentry_operations;
int hfsplus_write_begin(struct file *file, struct address_space *mapping,
loff_t pos, unsigned len, struct page **pagep, void **fsdata);
+void hfsplus_init_inode(struct hfsplus_inode_info *hip);
struct inode *hfsplus_new_inode(struct super_block *sb, struct inode *dir,
umode_t mode);
void hfsplus_delete_inode(struct inode *inode);
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 840577a0c1e7..d921b32d292e 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -379,22 +379,8 @@ static const struct file_operations hfsplus_file_operations = {
.unlocked_ioctl = hfsplus_ioctl,
};
-struct inode *hfsplus_new_inode(struct super_block *sb, struct inode *dir,
- umode_t mode)
+void hfsplus_init_inode(struct hfsplus_inode_info *hip)
{
- struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb);
- struct inode *inode = new_inode(sb);
- struct hfsplus_inode_info *hip;
-
- if (!inode)
- return NULL;
-
- inode->i_ino = sbi->next_cnid++;
- inode_init_owner(&init_user_ns, inode, dir, mode);
- set_nlink(inode, 1);
- inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode);
-
- hip = HFSPLUS_I(inode);
INIT_LIST_HEAD(&hip->open_dir_list);
spin_lock_init(&hip->open_dir_lock);
mutex_init(&hip->extents_lock);
@@ -412,6 +398,25 @@ struct inode *hfsplus_new_inode(struct super_block *sb, struct inode *dir,
hip->phys_size = 0;
hip->fs_blocks = 0;
hip->rsrc_inode = NULL;
+}
+
+struct inode *hfsplus_new_inode(struct super_block *sb, struct inode *dir,
+ umode_t mode)
+{
+ struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb);
+ struct inode *inode = new_inode(sb);
+ struct hfsplus_inode_info *hip;
+
+ if (!inode)
+ return NULL;
+
+ inode->i_ino = sbi->next_cnid++;
+ inode_init_owner(&init_user_ns, inode, dir, mode);
+ set_nlink(inode, 1);
+ inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode);
+
+ hip = HFSPLUS_I(inode);
+ hfsplus_init_inode(hip);
if (S_ISDIR(inode->i_mode)) {
inode->i_size = 2;
sbi->folder_count++;
--
2.31.1
next prev parent reply other threads:[~2022-12-15 7:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 8:18 [PATCH v2 0/2] initialize 'struct hfsplus_inode_info' in hfsplus_iget() ChenXiaoSong
2022-12-15 8:18 ` ChenXiaoSong [this message]
2022-12-15 8:18 ` [PATCH v2 2/2] hfsplus: fix uninit-value in hfsplus_delete_cat() ChenXiaoSong
2022-12-15 19:03 ` Viacheslav Dubeyko
2022-12-16 1:16 ` ChenXiaoSong
2022-12-16 18:09 ` Viacheslav Dubeyko
2022-12-17 2:20 ` ChenXiaoSong
2023-01-13 3:43 ` [PATCH v2 0/2] initialize 'struct hfsplus_inode_info' in hfsplus_iget() ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215081820.948990-2-chenxiaosong2@huawei.com \
--to=chenxiaosong2@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gargaditya08@live.com \
--cc=hannes@cmpxchg.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=slava@dubeyko.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®