From: Steven Rostedt <rostedt@goodmis.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] trace: allocate space from temparary trace sequence buffer
Date: Thu, 15 Dec 2022 08:23:45 -0500 [thread overview]
Message-ID: <20221215082345.56276315@gandalf.local.home> (raw)
In-Reply-To: <1671078807-20748-2-git-send-email-quic_linyyuan@quicinc.com>
On Thu, 15 Dec 2022 12:33:27 +0800
Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -95,6 +95,7 @@ extern void trace_seq_bitmask(struct trace_seq *s, const unsigned long *maskp,
> extern int trace_seq_hex_dump(struct trace_seq *s, const char *prefix_str,
> int prefix_type, int rowsize, int groupsize,
> const void *buf, size_t len, bool ascii);
> +void *trace_seq_alloc_buffer(struct trace_seq *s, int len);
So, I really don't like the name with "alloc" in it. That makes the
assumption that it also needs to be freed. Which it does not, and why it
confused me last night.
A better name would be trace_seq_acquire(s, len);
And it should return a char *, as it it process stings and not arbitrary
binary data.
> +/**
> + * trace_seq_alloc_buffer - allocate seq buffer with size len
> + * @s: trace sequence descriptor
> + * @len: size of buffer to be allocated
> + *
> + * allocate space with size of @len from seq buffer for output usage,
> + * On success, it returns start address of the allocated buffer,
> + * user can fill data start from the address, user should make sure the
> + * data length not exceed the @len, if it exceed, behavior is undefined.
> + *
> + * Returns NULL if no buffer can be allocated, it also means system will
> + * crash, it is user responsiblity to make sure total buffer used will
> + * not exceed PAGE_SIZE.
> + *
> + * it allow multiple usage in one trace output function call.
> + */
> +void *trace_seq_alloc_buffer(struct trace_seq *s, int len)
char *trace_seq_acquire(struct trace_seq *s, int len)
> +{
> + char *buf = trace_seq_buffer_ptr(s);
> +
You need to check the length first before committing:
if (seq_buf_buffer_left(&s->seq) < len)
return NULL;
> + seq_buf_commit(&s->seq, len);
Because the above is a bug if len is too big.
> +
> + if (unlikely(seq_buf_has_overflowed(&s->seq))) {
And then we don't need this either.
I must apologize for the response last night. It was past my normal bed
time, and I must really avoid reviewing patches when I should be going to
bed ;-)
-- Steve
> + s->full = 1;
> + return NULL;
> + }
> +
> + return (void *)buf;
> +}
> +EXPORT_SYMBOL(trace_seq_alloc_buffer);
next prev parent reply other threads:[~2022-12-15 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 4:33 [PATCH v1 1/2] trace: add new file under include/trace/stages/ for perf/bpf Linyu Yuan
2022-12-15 4:33 ` [PATCH v2 2/2] trace: allocate space from temparary trace sequence buffer Linyu Yuan
2022-12-15 4:54 ` Steven Rostedt
2022-12-15 5:08 ` Linyu Yuan
2022-12-15 12:09 ` Steven Rostedt
2022-12-15 13:23 ` Steven Rostedt [this message]
2022-12-16 2:05 ` Linyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215082345.56276315@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®