Hi Adrian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hid/for-next]
[also build test WARNING on linus/master v6.1 next-20221215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Adrian-Freund/HID-amd_sfh-Add-support-for-tablet-mode-switch-sensor/20221215-054325
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20221214214127.15347-1-adrian%40freund.io
patch subject: [PATCH] HID: amd_sfh: Add support for tablet-mode-switch sensor
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/9523955771c5517417b71bdcb1a19d8fadbc946d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Adrian-Freund/HID-amd_sfh-Add-support-for-tablet-mode-switch-sensor/20221215-054325
        git checkout 9523955771c5517417b71bdcb1a19d8fadbc946d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/hid/amd-sfh-hid/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c:15:
>> drivers/hid/amd-sfh-hid/sfh1_1/../hid_descriptor/amd_sfh_hid_report_desc.h:649:17: warning: 'tms_report_descriptor' defined but not used [-Wunused-const-variable=]
     649 | static const u8 tms_report_descriptor[] = {
         |                 ^~~~~~~~~~~~~~~~~~~~~


vim +/tms_report_descriptor +649 drivers/hid/amd-sfh-hid/sfh1_1/../hid_descriptor/amd_sfh_hid_report_desc.h

   646	
   647	
   648	/* TABLET MODE SWITCH */
 > 649	static const u8 tms_report_descriptor[] = {
   650	0x06, 0x43, 0xFF,  // Usage Page (Vendor Defined 0xFF43)
   651	0x0A, 0x02, 0x02,  // Usage (0x0202)
   652	0xA1, 0x01, // Collection (Application)
   653	0x85, 0x11, //   Report ID (17)
   654	0x15, 0x00, //   Logical Minimum (0)
   655	0x25, 0x01, //   Logical Maximum (1)
   656	0x35, 0x00, //   Physical Minimum (0)
   657	0x45, 0x01, //   Physical Maximum (1)
   658	0x65, 0x00, //   Unit (None)
   659	0x55, 0x00, //   Unit Exponent (0)
   660	0x75, 0x01, //   Report Size (1)
   661	0x95, 0x98, //   Report Count (-104)
   662	0x81, 0x03, //   Input (Const,Var,Abs,No Wrap,Linear,Preferred State,No Null Position)
   663	0x91, 0x03, //   Output (Const,Var,Abs,No Wrap,Linear,Preferred State,No Null Position,Non-volatile)
   664	0xC1, 0x00, // End Collection
   665	};
   666	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp