mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
	boqun.feng@gmail.com, neeraj.iitr10@gmail.com, urezki@gmail.com,
	rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] srcu: Yet more detail for srcu_readers_active_idx_check() comments
Date: Thu, 15 Dec 2022 11:58:54 -0800	[thread overview]
Message-ID: <20221215195854.GL4001@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <CAEXW_YTSW9kr3DsJm6hTQ0FfwVbVjzDa8=7H29+ysD10ZCbnHA@mail.gmail.com>

On Thu, Dec 15, 2022 at 05:48:46PM +0000, Joel Fernandes wrote:
> On Thu, Dec 15, 2022 at 5:08 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> 
> > > Scenario for the reader to increment the old idx once:
> > >
> > > _ Assume ssp->srcu_idx is initially 0.
> > > _ The READER reads idx that is 0
> > > _ The updater runs and flips the idx that is now 1
> > > _ The reader resumes with 0 as an index but on the next srcu_read_lock()
> > >   it will see the new idx which is 1
> > >
> > > What could be the scenario for it to increment the old idx twice?
> >
> > Unless I am missing something, the reader must reference the
> > srcu_unlock_count[old_idx] and then do smp_mb() before it will be
> > absolutely guaranteed of seeing the new value of ->srcu_idx.
> 
> I think both of you are right depending on how the flip raced with the
> first reader's unlock in that specific task.

There are indeed a variety of scenarios and also a variety of failure
cases.

> If the first read section's srcu_read_unlock() and its corresponding
> smp_mb()  happened before the flip, then the increment of old idx
> would happen only once. The next srcu_read_lock() will read the new
> index. If the srcu_read_unlock() and it's corresponding smp_mb()
> happened after the flip, the old_idx will be sampled again and can be
> incremented twice. So it depends on how the flip races with
> srcu_read_unlock().

I do understand that a number of people like reasoning about
memory-barrier ordering, courtesy of the sequentially consistent portions
of the C and C++ memory models, but thinking in terms of the accesses
surrounding the memory barriers has been far less error-prone.

> Also, since this is all hard to reason about I started making some
> diagrams, LOL. For your amusement, here is why need to scan both idx
> during grace period detection: https://i.imgur.com/jz4bNKd.png

Nice!

I suggest placing a gap between GP 2 and GP 3.  That way, you can make it
very clear that Reader 1's critical section starts after the end of GP 2
(thus clearly never blocking GP 2) and before GP 3 (thus possibly having
a reference to some data that is going to be freed at the end of GP 3).

I also suggest coloring Reader 1 red and Reader 2 green, given that the
color red generally indicates danger.

							Thanx, Paul

  parent reply	other threads:[~2022-12-15 19:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 19:13 Paul E. McKenney
2022-12-14 20:51 ` Joel Fernandes
2022-12-14 21:24   ` Paul E. McKenney
2022-12-14 23:07     ` Joel Fernandes
2022-12-14 23:10       ` Joel Fernandes
2022-12-14 23:14         ` Joel Fernandes
2022-12-15  0:04           ` Paul E. McKenney
2022-12-15  1:34             ` Joel Fernandes
2022-12-15  1:39               ` Paul E. McKenney
2022-12-15  0:01       ` Paul E. McKenney
2022-12-15 16:54 ` Frederic Weisbecker
2022-12-15 17:08   ` Paul E. McKenney
2022-12-15 17:48     ` Joel Fernandes
2022-12-15 17:58       ` Joel Fernandes
2022-12-15 20:13         ` Paul E. McKenney
2022-12-15 22:13           ` Joel Fernandes
2022-12-15 22:22             ` Joel Fernandes
2022-12-16  1:13               ` Paul E. McKenney
2022-12-16  1:09             ` Paul E. McKenney
2022-12-16 16:32               ` Joel Fernandes
2022-12-16 16:39                 ` Joel Fernandes
2022-12-16 16:51                 ` Paul E. McKenney
2022-12-16 16:54                   ` Joel Fernandes
2022-12-16 17:13                     ` Paul E. McKenney
2022-12-17  3:19                     ` Joel Fernandes
2022-12-17  3:21                       ` Joel Fernandes
2022-12-17  5:15                         ` Paul E. McKenney
2022-12-17  6:32                           ` Joel Fernandes
2022-12-15 19:58       ` Paul E. McKenney [this message]
2022-12-15 20:03         ` Joel Fernandes
2022-12-15 20:33           ` Joel Fernandes
2022-12-15 21:39             ` Paul E. McKenney
2022-12-15 21:42               ` Joel Fernandes
2022-12-15 22:10                 ` Paul E. McKenney
2022-12-15 22:16                   ` Joel Fernandes
2022-12-15 17:58     ` Frederic Weisbecker
2022-12-15 18:53       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215195854.GL4001@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.iitr10@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®