From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7ACDC10F1E for ; Fri, 16 Dec 2022 01:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiLPBpt (ORCPT ); Thu, 15 Dec 2022 20:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiLPBpo (ORCPT ); Thu, 15 Dec 2022 20:45:44 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5CA52646; Thu, 15 Dec 2022 17:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671155143; x=1702691143; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XidVk7e1oIaU8sSsWlZDRhszxAli6ATjq+ERwzA5CMs=; b=bKk+ofsbvTnCUQ5ZQxItJXY4P1FBHsAlYjjAPTBIEOt/6epL0LZCiDi0 x6zxl8oDm7VUnDsr3Ptgsy3eggpoCBUhUkTgocxUmoGickF1gpVAaHL6K FV0hyetx8ro8sW3wtWBVldUm8EnH/LTudkPuL5EugzVebB+mcL0qvX+jF eHncgIej90czj5YSK0pvqOoK9n4XJLoZluFfWe+ePXC01Yq87tKLp0R7E lvBR9dLwN0m+f/bxEf0RCKvAfsz75By8Cfk6c1lYOPs4by9coU9EuFC4J uDo0MZz1GLVD8uQyb0lnPX1cKNdrh/E16wNBTbUdvV6dojABbi70i/QuV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="316497957" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="316497957" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 17:45:43 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="791887103" X-IronPort-AV: E=Sophos;i="5.96,248,1665471600"; d="scan'208";a="791887103" Received: from xintongc-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.168.175]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 17:45:40 -0800 Date: Fri, 16 Dec 2022 09:45:38 +0800 From: Yu Zhang To: Sean Christopherson Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: nVMX: Remove outdated comments in nested_vmx_setup_ctls_msrs(). Message-ID: <20221216014538.3yx5mnmwz2vaa5cy@linux.intel.com> References: <20221215100558.1202615-1-yu.c.zhang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Eh, just drop the comment. Pretty obvious this is for secondary execution controls. Thanks Sean. Well, I agree it is obvious. This line was kept because there are comments for other groups of control fields(e.g., exit/entry/pin-based/cpu-based controls etc.) in nested_vmx_setup_ctls_msrs(). If we do not keep the one for secondary cpu-based controls, we may just delete other comments as well. But is that really necessary? B.R. Yu