From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC0AC4332F for ; Sat, 17 Dec 2022 04:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbiLQEwP (ORCPT ); Fri, 16 Dec 2022 23:52:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbiLQEwI (ORCPT ); Fri, 16 Dec 2022 23:52:08 -0500 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2134.outbound.protection.outlook.com [40.107.255.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0AB46153A for ; Fri, 16 Dec 2022 20:52:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLS8uPZwK2bI/iZ9p4opvH9N9XBWuMeqqLkNr4JaK4TEMKcUQRx+Uz8YvN2WLcrWkJo/8Pz3Y52QSxgMseAqjw8g2P9p7A4/phdsYl7rnYQdPM5Sg4GQErgbe20gpJ6sCVX/T06mzUUDdSwrONWpH7MJiwKslee4/rDYuVotVriZo38OEvHKl27mycx8fVpnju4qOQs9YhH5gaUvhkhesaunQymydjBra3pK4xrUUx1qTVMKmjqBTbFantoasuOuKF5WEZEqDTsVKMsL5MzGu/8e0lcmn/pjxVWOovwgSFx3d54cLrgBHX0kxBdrQCEVgug73lBQQaXkFdTA0VYtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k0CuqBwJ5lRRxt79r9iTsFmabkWW1LCP8Nwvvg4/CzU=; b=EqAtkYvM6NydyWosa3buYlOZx8hpF3F7SubiZMScx61A5XwA11l+R46S45rwDvnW1OxWHPxx7TG2DGGds4uF4fKfejAiFx9wUdUBtvF1WK0orfrJWkoJdS4SmPePhUOyjxylj0cYsa3v0n6dV7TvHFb2ryoyXvubu9+v7pKxAxEZ92rDWoaN9Dbl0EDJIthxylQVVczcI8mQGHSmchK8uSbGRkBI5EP7yNJnzaupXGzZt439yYVUcZbe+WFaJP/4tv9TvGS1Svl7opXur7XDee1LR/tpbUxWl3Dpo5UjD6+SphhGRwvH6ubscadHbQ0ZrfnWU81g+w//aqibBMqnmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k0CuqBwJ5lRRxt79r9iTsFmabkWW1LCP8Nwvvg4/CzU=; b=NyTktvoxgeNQXGBV1xGZx9bHRqXJLSENbhnpfLLPlE0WlSMQiBpzBUZcA+7V/IckB2OqTqDGT2vpyG4hO7JdKPyhRMziHK7S0kI5vSnhb/sAxEFjjeRhDPEFA4OnV6lOWnEKonTz/adC3Dzwr19Qc8A81WY4lR4zDbgRMiDjJRAl9bZ5n4vuifGAHSss8n42co/cJQRtJ9w8RTsxEP3SThPYRMu4ae2sABF0/OCmibfNvlhRxKmsD8flh8lyWkk6XB0vQtD+UPHC8yA5dVy5/GK8jZCeY2pQqPPi6gSM092bP4ZTVIaYCsHlzmFSEkyle1t61xzmY6uUXVOECqPG+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6020.apcprd06.prod.outlook.com (2603:1096:820:d8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.14; Sat, 17 Dec 2022 04:52:01 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::ef03:cbfb:f8ef:d88b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::ef03:cbfb:f8ef:d88b%9]) with mapi id 15.20.5924.016; Sat, 17 Dec 2022 04:52:00 +0000 From: Yangtao Li To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: merge f2fs_show_injection_info() into time_to_inject() Date: Sat, 17 Dec 2022 12:51:51 +0800 Message-Id: <20221217045151.56195-1-frank.li@vivo.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <0377292c-ba43-06cd-2638-8e41e2e75f3a@kernel.org> References: <0377292c-ba43-06cd-2638-8e41e2e75f3a@kernel.org> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI1PR02CA0046.apcprd02.prod.outlook.com (2603:1096:4:1f5::14) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6020:EE_ X-MS-Office365-Filtering-Correlation-Id: d70fef0e-06e2-486d-60d0-08dadfea6ee7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xKJI+Ry11jLpXmMNY8H1vGXsRHq4x8qvsffOVjrgdsKO2KY3MO6dXcxnLFrjABYpE8heRnT5QBs4zRaGkpDcNBEtTudXigiR2SaiD4tXI+g+7gQN2IxqrQALzaG5xc22sasO/XcU/+gwrzcfLswMH+ycTFiWjYyUJv7eRaEoiOxgdjguine5LO9Gb5W5GOW/Arl6ZQE7SejWs3NayinRQ69mb9JR8QY+MapQxlKJcmdsGIDBrGq5+y2sAxcLBZQh9++XbRXWKsDjP8wFVx5EwZWuy4f+2Qz5VCeDqCiTpljTaTaU4HBR1thtMQdBNzmyA2N43bEGXqEHHqM5xpdvNhWmY/cF6rm0YwoMmnCtW1xp9gMQnGUH8+VYmTnSIK9mZ5PQxqcbYDCeEIaiOV+Uc6Arspo7YvMG+Da4eBGKSNw3khIiLjdaQprsJh/En4Avzd9Gi6eYhkgVRgDYvxIl40LsBEYe5PHTjdNpBGmsEJwu7fiKiX1JotVht5J1Gm9LcFppH0A2ZU/o95Uk4A2cSApluYy1rWocDwkoXAjOvfDsR7w1yHJzPLSgGJQFLpdf1uj46Qj8AaCno/9Sx5AHD70lD5uck/OhyxHQNt9BltkpvI6soXh5yo3bN+sOyhOznMH1uWQBJIlZZzvS69qMZHT03tYZG5IPoyUQPHFendm1o3DDfoXoFJYUaKowvY/6cM7pYINfm/3xRPt1y5eAlA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199015)(5660300002)(4326008)(8676002)(8936002)(66556008)(66946007)(66476007)(41300700001)(4744005)(52116002)(478600001)(316002)(36756003)(2906002)(6486002)(2616005)(1076003)(86362001)(6666004)(6512007)(26005)(6506007)(186003)(83380400001)(38100700002)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RIpbMSl+MHsEYg4XVLCNfcWn0TlS20qApKASybgFBaRHFPlp5mfogjonOOgG?= =?us-ascii?Q?S2uk4HpaoNSSIUMAPuibdZOBNpABra2KQSk2h33lqQ4IWS0w3ABHtaxz3Jj4?= =?us-ascii?Q?qz30WH9BUzlOq4tEEhNNwt0oAqck4z/OUTjp0xDp3+NcWubMkGl1cHLIGCAp?= =?us-ascii?Q?GbFGopMKBLjxjIhXhB8G/Ovj+LALzbH09Mf9NI/T56c1HAcXClTFp5Zen3ZI?= =?us-ascii?Q?YJ2cL780JtcrnAW8zt4HCsczceVXYw6mSuTqy3oOydC0rCVD9k6AOzsZojaY?= =?us-ascii?Q?kK61ii+P1k1iG34uBhAOW9RXA4v3CJ5QjsfkeaSO5pnGFHsqiObTFfmpzz4w?= =?us-ascii?Q?qFry/GA7GwuLF0phgYrYa+Bm4UbYouMViJlOgC5Jzwzje+3g5Nf/G+K5JwkZ?= =?us-ascii?Q?9XHNVVJs7W0YY243KAzVt3OxvsSdGp28Yse+Boj86NxFYxngyXC4nhAgFldy?= =?us-ascii?Q?EuNU67B5nGtlG7iyQWmURXsWv4a0VAYM7PhBmU/NOf3/8VOSEGqKD4oqqtrf?= =?us-ascii?Q?zOvO30ZLxxlu6IWsVK4/9GGczFHziUz7ZSkESS02PWphV5f1YeKASeooNxMf?= =?us-ascii?Q?SYBSSIaOSj4Ljl4fNUwWKFeqKn703Jf5JyBNf3rkvEyZG/QH8v4q1pyrQK39?= =?us-ascii?Q?hxQAsFmQsL9Gp7DNgkt8+Vjreelw2WtyEhm3/kajVLGJfwqNwgK+rUC1cF7r?= =?us-ascii?Q?RZG8yKQrpkcKy3Qn0GiWg7Kg2YgKiOF2Wq5pFthHsEFNVK1mOYzSPpCVVzr8?= =?us-ascii?Q?71AvJUIr7Kz0yTQXDXetPnRFUete8JOAW/SlnxL8I4ElGl9EGbH8DtEW3RBo?= =?us-ascii?Q?dvKlbjLYvPFRz/5741itHHJEDfhZyWMQVii2gUo/nXzXeq41Yk/Ntzl1Z3sU?= =?us-ascii?Q?aIPAAhCZQf8/7Ariljxb2M6XQsZ466PxP6DYAHLafRZlyxci2lBCos2dxLrH?= =?us-ascii?Q?/RYoiwCl5b2PejlfRh0xVXnheawrNWiAdsTr66xMv40qVHcwpGX9+WL21d1S?= =?us-ascii?Q?bxeYAj74u+ADUh98sO1dmn271L0hC7GpXHZQLlHhkcGTg/iGP8rfWdO30dsZ?= =?us-ascii?Q?y/0yAHxczLqJcv8Io1Awz3JBUXgXYxg/5MFDeBo86iEgSRysCb+r/0it8JwJ?= =?us-ascii?Q?6dp10jt1FA2r0cKacJ9LhUZ43hmDDDk1r6dgDGqY3sX7j5uCnHGd8dCwk4r4?= =?us-ascii?Q?pOZXD29jCitZQXqJppPn33OgZIDGM1V2Lknntrv2p/i9QWizIHrJqgWZdsre?= =?us-ascii?Q?Tr2++KQRymQY6PoMZIaCcWhDYCmPnUWeQz+hgJbcp2USVk6jP9ZYTnQEiuHU?= =?us-ascii?Q?Z8irTb3/8ppJ2fsSsqTOQiFLbTE8+Tv/oVVsJIigT/SOULkh+6E12P2U0xEN?= =?us-ascii?Q?kF4saBdXhnEPSb027a1FfWkMk137glu4DKldYSib6OpBDwhE3+G+MpeRcA2x?= =?us-ascii?Q?qWd4aQEZtaoBWcPFPQhRhzIXRK1QTcZcvMdm1667N7e0Llg2GifMizEn7s9r?= =?us-ascii?Q?lKW817pvK99OSML0uTMFZomy/WOqgz49yLyJudySxK4ZInjpqgSNAjmz3hyn?= =?us-ascii?Q?EgXuSAJWOn1+lxbjKSY5EozPBvWWkabdqei7rD1N?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d70fef0e-06e2-486d-60d0-08dadfea6ee7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2022 04:52:00.5157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pF2o0lImHlbZlivUY5jC2E2DNGUasOKjfazEgQyEpflWj3fEdyeEllj8/UXFHHIxDhJBr+PK7K/n0VSFTnpXDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6020 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, > Yeah, but it depends on compile option, right? If user use -O0 or -fno-inline option, inline function will not be expanded... This is not a problem, we just need to mark it as __always_inline. static __always_inline bool __time_to_inject(struct f2fs_sb_info *sbi, int type, const char *func_name) > How about using deterministic implementation? This way works, or do you have a better suggestion. After marking the function as __always_inline, there will be no problem you mentioned. Thx, Yangtao